Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1338163003: Remove transitional GN code. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove transitional GN code. The conditionals were added to facilitate a two-sided build GN config update where the default optimization config was renamed. This is complete so the transitional code can be removed. Committed: https://crrev.com/7ec3be731fa53fe50af88dd59829fccb34836c0f Cr-Commit-Position: refs/heads/master@{#30733}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M BUILD.gn View 1 3 chunks +3 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
Feel free to press the CQ button. Thanks!
5 years, 3 months ago (2015-09-14 23:02:36 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-15 07:36:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338163003/20001
5 years, 3 months ago (2015-09-15 07:36:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-15 08:43:32 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 08:43:43 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ec3be731fa53fe50af88dd59829fccb34836c0f
Cr-Commit-Position: refs/heads/master@{#30733}

Powered by Google App Engine
This is Rietveld 408576698