Add Async API unittests to readback format.

Add Async API unittests to readback format.
Current code doesnt have the async way to readback texture with
different formats.

BUG=323150
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247113

[sivag, 2014-01-23 14:14:33]

PTAL..

[piman, 2014-01-23 20:43:56]

https://codereview.chromium.org/133813003/diff/1/content/common/gpu/client/gl...
File content/common/gpu/client/gl_helper.cc (right):

https://codereview.chromium.org/133813003/diff/1/content/common/gpu/client/gl...
content/common/gpu/client/gl_helper.cc:487: const base::Callback<void(bool)>&
callback) {
Can you add DCHECKs on the supported formats?

https://codereview.chromium.org/133813003/diff/1/content/common/gpu/client/gl...
content/common/gpu/client/gl_helper.cc:503: readback_config_rgb565,
This would change when rebasing on top of your
https://codereview.chromium.org/143683003/ , right?

If you're using git, what you can do is:
- rebase the branch for this CL on top of the branch for
https://codereview.chromium.org/143683003/
- use git set-upstream-to to ensure this branch is tracking the other branch

Then git cl upload will upload the diff between this branch and the other branch
(as opposed to origin/master), and will give the correct diff.

[sivag, 2014-01-24 15:56:40]

PTAL...

https://codereview.chromium.org/133813003/diff/1/content/common/gpu/client/gl...
File content/common/gpu/client/gl_helper.cc (right):

https://codereview.chromium.org/133813003/diff/1/content/common/gpu/client/gl...
content/common/gpu/client/gl_helper.cc:487: const base::Callback<void(bool)>&
callback) {
On 2014/01/23 20:43:57, piman wrote:
> Can you add DCHECKs on the supported formats?

Done.

https://codereview.chromium.org/133813003/diff/1/content/common/gpu/client/gl...
content/common/gpu/client/gl_helper.cc:503: readback_config_rgb565,
On 2014/01/23 20:43:57, piman wrote:
> This would change when rebasing on top of your
> https://codereview.chromium.org/143683003/ , right?
> 
> If you're using git, what you can do is:
> - rebase the branch for this CL on top of the branch for
> https://codereview.chromium.org/143683003/
> - use git set-upstream-to to ensure this branch is tracking the other branch
> 
> Then git cl upload will upload the diff between this branch and the other
branch
> (as opposed to origin/master), and will give the correct diff.

Thanks for sharing this tip :). As my branches are in different workspace i
tried this but finally due to some issue i did the rebase after the patch got
commited. I Will definitely use this tip When i face the same situation again.

[piman, 2014-01-24 20:26:31]

LGTM + 1 nit.

https://codereview.chromium.org/133813003/diff/70001/content/common/gpu/clien...
File content/common/gpu/client/gl_helper.cc (right):

https://codereview.chromium.org/133813003/diff/70001/content/common/gpu/clien...
content/common/gpu/client/gl_helper.cc:561: int bytes_per_pixel =
readback_config_rgb565 ? 2 : 4;
nit: you're not otherwise using readback_config_rgb565 anymore, so coalesce
these 2 lines:

int bytes_per_pixel = (config == SkBitmap::kRGB_565_Config) ? 2 : 4;

(also note, single space after ==)

[sivag, 2014-01-25 08:34:01]

Done.

https://codereview.chromium.org/133813003/diff/70001/content/common/gpu/clien...
File content/common/gpu/client/gl_helper.cc (right):

https://codereview.chromium.org/133813003/diff/70001/content/common/gpu/clien...
content/common/gpu/client/gl_helper.cc:561: int bytes_per_pixel =
readback_config_rgb565 ? 2 : 4;
On 2014/01/24 20:26:31, piman wrote:
> nit: you're not otherwise using readback_config_rgb565 anymore, so coalesce
> these 2 lines:
> 
> int bytes_per_pixel = (config == SkBitmap::kRGB_565_Config) ? 2 : 4;
> 
> (also note, single space after ==)

Done.

[commit-bot: I haz the power, 2014-01-25 08:34:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/siva.gunturi@samsung.com/133813003/140001

[commit-bot: I haz the power, 2014-01-25 09:59:04]

Change committed as 247113