Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1338093002: android: Include rect_f.h to use RectF. (Closed)

Created:
5 years, 3 months ago by danakj
Modified:
5 years, 3 months ago
CC:
bondd+autofillwatch_chromium.org, chromium-reviews, estade+watch_chromium.org, gcasto+watchlist_chromium.org, jdonnelly+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org, piman, rouslan+autofill_chromium.org, sky, vabr+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Include rect_f.h to use RectF. The file includes rect.h now but that's the wrong one. TBR=aurimas@chromium.org BUG=342848 Committed: https://crrev.com/2a78a3b7119e3f139b5117749ba76bc77a4c5bbd Cr-Commit-Position: refs/heads/master@{#348513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
danakj
Found another file that did the same thing.
5 years, 3 months ago (2015-09-12 00:17:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338093002/1
5 years, 3 months ago (2015-09-12 00:17:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-12 00:44:42 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2a78a3b7119e3f139b5117749ba76bc77a4c5bbd Cr-Commit-Position: refs/heads/master@{#348513}
5 years, 3 months ago (2015-09-12 00:45:17 UTC) #5
aurimas (slooooooooow)
lgtm
5 years, 3 months ago (2015-09-12 00:46:58 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:27:28 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2a78a3b7119e3f139b5117749ba76bc77a4c5bbd
Cr-Commit-Position: refs/heads/master@{#348513}

Powered by Google App Engine
This is Rietveld 408576698