Refactor fxjs_v8 and add embeddertests for it.

fpdfsdk/include/jsapi/fxjs_v8.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 // PDFium wrapper around V8 APIs. PDFium code should include this file rather
 // than including V8 headers directly.
 
 #ifndef FPDFSDK_INCLUDE_JSAPI_FXJS_V8_H_
@@ skipping 30 matching lines @@
 extern const wchar_t kFXJSValueNameBoolean[];
 extern const wchar_t kFXJSValueNameDate[];
 extern const wchar_t kFXJSValueNameObject[];
 extern const wchar_t kFXJSValueNameFxobj[];
 extern const wchar_t kFXJSValueNameNull[];
 extern const wchar_t kFXJSValueNameUndefined[];
 
 class IFXJS_Context;
 class IFXJS_Runtime;
 
+class JS_ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
+  void* Allocate(size_t length) override;
+  void* AllocateUninitialized(size_t length) override;
+  void Free(void* data, size_t length) override;
+};
+
 typedef void (*LP_CONSTRUCTOR)(IFXJS_Context* cc,
                                v8::Local<v8::Object> obj,
                                v8::Local<v8::Object> global);
 typedef void (*LP_DESTRUCTOR)(v8::Local<v8::Object> obj);
 
+// Call before making JS_PrepareIsolate call.
+void JS_Initialize(unsigned int embedderDataSlot);
+void JS_Release();
+
+// Call before making JS_Define* calls. Resources allocated here are cleared
+// as part of JS_ReleaseRunime().
+void JS_PrepareIsolate(v8::Isolate* pIsolate);
+
 // Always returns a valid, newly-created objDefnID.
 int JS_DefineObj(v8::Isolate* pIsolate,
                  const wchar_t* sObjName,
                  FXJSOBJTYPE eObjType,
                  LP_CONSTRUCTOR pConstructor,
                  LP_DESTRUCTOR pDestructor);
 
 void JS_DefineObjMethod(v8::Isolate* pIsolate,
                         int nObjDefnID,
                         const wchar_t* sMethodName,
@@ skipping 13 matching lines @@
                        int nObjDefnID,
                        const wchar_t* sConstName,
                        v8::Local<v8::Value> pDefault);
 void JS_DefineGlobalMethod(v8::Isolate* pIsolate,
                            const wchar_t* sMethodName,
                            v8::FunctionCallback pMethodCall);
 void JS_DefineGlobalConst(v8::Isolate* pIsolate,
                           const wchar_t* sConstName,
                           v8::Local<v8::Value> pDefault);
 
+// Called after JS_Define* calls made.
 void JS_InitialRuntime(v8::Isolate* pIsolate,

[Tom Sepez, 2015/09/15 15:57:44]

I suppose you want this named "initialize", too ... hang on.

                        IFXJS_Runtime* pFXRuntime,
                        IFXJS_Context* context,
                        v8::Global<v8::Context>& v8PersistentContext);
 void JS_ReleaseRuntime(v8::Isolate* pIsolate,
                        v8::Global<v8::Context>& v8PersistentContext);
-void JS_Initial(unsigned int embedderDataSlot);
-void JS_Release();
+
+// Called after JS_InitialRuntime call made.
 int JS_Execute(v8::Isolate* pIsolate,
                IFXJS_Context* pJSContext,
                const wchar_t* script,
                long length,
                FXJSErr* perror);
+
 v8::Local<v8::Object> JS_NewFxDynamicObj(v8::Isolate* pIsolate,
                                          IFXJS_Context* pJSContext,
                                          int nObjDefnID);
 v8::Local<v8::Object> JS_GetStaticObj(v8::Isolate* pIsolate, int nObjDefnID);
 v8::Local<v8::Object> JS_GetThisObj(v8::Isolate* pIsolate);
 int JS_GetObjDefnID(v8::Local<v8::Object> pObj);
 v8::Isolate* JS_GetRuntime(v8::Local<v8::Object> pObj);
 int JS_GetObjDefnID(v8::Isolate* pIsolate, const wchar_t* pObjName);
 void JS_Error(v8::Isolate* isolate, const CFX_WideString& message);
 unsigned JS_CalcHash(const wchar_t* main, unsigned nLen);
@@ skipping 86 matching lines @@
 int JS_GetMinFromTime(double dt);
 int JS_GetSecFromTime(double dt);
 double JS_DateParse(const wchar_t* string);
 double JS_MakeDay(int nYear, int nMonth, int nDay);
 double JS_MakeTime(int nHour, int nMin, int nSec, int nMs);
 double JS_MakeDate(double day, double time);
 bool JS_PortIsNan(double d);
 double JS_LocalTime(double d);
 
 #endif  // FPDFSDK_INCLUDE_JSAPI_FXJS_V8_H_