Refactor fxjs_v8 and add embeddertests for it.

fpdfsdk/src/jsapi/fxjs_v8.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../core/include/fxcrt/fx_basic.h"
 #include "../../../core/include/fxcrt/fx_ext.h"
 #include "../../include/jsapi/fxjs_v8.h"
 #include "../../include/fsdk_define.h"
@@ skipping 57 matching lines @@
   const wchar_t* objName;
   FXJSOBJTYPE objType;
   LP_CONSTRUCTOR m_pConstructor;
   LP_DESTRUCTOR m_pDestructor;
   FX_BOOL m_bSetAsGlobalObject;
 
   v8::Global<v8::ObjectTemplate> m_objTemplate;
   v8::Global<v8::Object> m_StaticObj;
 };
 
+void* JS_ArrayBufferAllocator::Allocate(size_t length) {
+  return calloc(1, length);
+}
+
+void* JS_ArrayBufferAllocator::AllocateUninitialized(size_t length) {
+  return malloc(length);
+}
+
+void JS_ArrayBufferAllocator::Free(void* data, size_t length) {
+  free(data);
+}
+
+void JS_PrepareIsolate(v8::Isolate* pIsolate) {
+  if (!pIsolate->GetData(g_embedderDataSlot))
+    pIsolate->SetData(g_embedderDataSlot, new CFX_PtrArray());
+}
+
+void JS_ResetIsolate(v8::Isolate* pIsolate) {
+  delete (CFX_PtrArray*)pIsolate->GetData(g_embedderDataSlot);
+  pIsolate->SetData(g_embedderDataSlot, nullptr);
+}
+
 int JS_DefineObj(v8::Isolate* pIsolate,
                  const wchar_t* sObjName,
                  FXJSOBJTYPE eObjType,
                  LP_CONSTRUCTOR pConstructor,
                  LP_DESTRUCTOR pDestructor) {
   v8::Isolate::Scope isolate_scope(pIsolate);
   v8::HandleScope handle_scope(pIsolate);
+
+  JS_PrepareIsolate(pIsolate);
   CFX_PtrArray* pArray = (CFX_PtrArray*)pIsolate->GetData(g_embedderDataSlot);
-  if (!pArray) {
-    pArray = new CFX_PtrArray();
-    pIsolate->SetData(g_embedderDataSlot, pArray);
-  }
   CJS_ObjDefintion* pObjDef = new CJS_ObjDefintion(pIsolate, sObjName, eObjType,
                                                    pConstructor, pDestructor);
   pArray->Add(pObjDef);
   return pArray->GetSize() - 1;
 }
 
 void JS_DefineObjMethod(v8::Isolate* pIsolate,
                         int nObjDefnID,
                         const wchar_t* sMethodName,
                         v8::FunctionCallback pMethodCall) {
@@ skipping 221 matching lines @@
     if (!pObjDef->m_StaticObj.IsEmpty()) {
       v8::Local<v8::Object> pObj =
           v8::Local<v8::Object>::New(pIsolate, pObjDef->m_StaticObj);
       if (pObjDef->m_pDestructor)
         pObjDef->m_pDestructor(pObj);
       JS_FreePrivate(pObj);
     }
     delete pObjDef;
   }
   delete pArray;
   pIsolate->SetData(g_embedderDataSlot, NULL);

[Lei Zhang, 2015/09/15 01:59:55]

I guess this is where we would call JS_ResetIsolate(), except we already called
GetData() above.

[Tom Sepez, 2015/09/15 15:56:42]

Removed JS_ResetIsolate, added comment about this doing everything.

 }
 
 void JS_Initial(unsigned int embedderDataSlot) {
   g_embedderDataSlot = embedderDataSlot;
 }
 
 void JS_Release() {
 }
 
 int JS_Execute(v8::Isolate* pIsolate,
@@ skipping 744 matching lines @@
 
 bool JS_PortIsNan(double d) {
   return d != d;
 }
 
 double JS_LocalTime(double d) {
   return JS_GetDateTime() + _getDaylightSavingTA(d);
 }
 
 // JavaScript time implement End.