Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1338063002: Cleanup stale TODO comments in ChunkDemuxerTest (Closed)

Created:
5 years, 3 months ago by chcunningham
Modified:
5 years, 3 months ago
Reviewers:
wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup stale TODO comments in ChunkDemuxerTest BUG=354284 Committed: https://crrev.com/cb59acff7a8248be46a05fcbb8be38f9618121de Cr-Commit-Position: refs/heads/master@{#348770}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M media/filters/chunk_demuxer_unittest.cc View 5 chunks +10 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
chcunningham
Here's an easy one ;) Bumped into this while updating the code for WebM audio ...
5 years, 3 months ago (2015-09-11 22:52:37 UTC) #2
wolenetz
lgtm thanks! https://codereview.chromium.org/1338063002/diff/1/media/filters/chunk_demuxer_unittest.cc File media/filters/chunk_demuxer_unittest.cc (right): https://codereview.chromium.org/1338063002/diff/1/media/filters/chunk_demuxer_unittest.cc#newcode763 media/filters/chunk_demuxer_unittest.cc:763: // duration in the init segment. this ...
5 years, 3 months ago (2015-09-14 23:02:21 UTC) #3
wolenetz
On 2015/09/14 23:02:21, wolenetz wrote: > lgtm thanks! > > https://codereview.chromium.org/1338063002/diff/1/media/filters/chunk_demuxer_unittest.cc > File media/filters/chunk_demuxer_unittest.cc (right): ...
5 years, 3 months ago (2015-09-14 23:15:59 UTC) #4
chcunningham
Thanks Matt
5 years, 3 months ago (2015-09-14 23:18:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338063002/20001
5 years, 3 months ago (2015-09-14 23:19:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-14 23:46:52 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/cb59acff7a8248be46a05fcbb8be38f9618121de Cr-Commit-Position: refs/heads/master@{#348770}
5 years, 3 months ago (2015-09-14 23:47:34 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:39:19 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/cb59acff7a8248be46a05fcbb8be38f9618121de
Cr-Commit-Position: refs/heads/master@{#348770}

Powered by Google App Engine
This is Rietveld 408576698