[Telemetry] Refactor Chrome devtools tracing

[Telemetry] Refactor Chrome devtools tracing

Platform-level tracing doc:
https://docs.google.com/document/d/1Uv8SzOq2ugvzLiOcP85g7qPiaxwsn4tgOdxpe3YjUkM/edit?usp=sharing

BUG=515323
Committed: https://crrev.com/cbecca3af4042fbf593dead4c12cfdd22cfd2310
Cr-Commit-Position: refs/heads/master@{#348740}

[Zhen Wang, 2015-09-11 22:31:27]

zhenw@chromium.org changed reviewers:
+ nednguyen@google.com

[Zhen Wang, 2015-09-11 22:31:28]

ptal

[nednguyen, 2015-09-14 20:12:04]

lgtm

https://codereview.chromium.org/1338033002/diff/1/tools/telemetry/telemetry/i...
File
tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_devtools_manager.py
(right):

https://codereview.chromium.org/1338033002/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_devtools_manager.py:1:
# Copyright 2014 The Chromium Authors. All rights reserved.
2015

https://codereview.chromium.org/1338033002/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_devtools_manager.py:28:
def RegisterDevToolsClient(devtools_client_backend, platform_backend):
Can you add some comment about this should only be called from
DevtoolClientBackend?
I know no good way to enforce this, so if you have any better idea, it would be
great.

https://codereview.chromium.org/1338033002/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_devtools_manager.py:60:
def GetNonStaleDevToolsClients(platform_backend):
GetActiveDevtoolsClient

[Zhen Wang, 2015-09-14 20:24:51]

https://codereview.chromium.org/1338033002/diff/1/tools/telemetry/telemetry/i...
File
tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_devtools_manager.py
(right):

https://codereview.chromium.org/1338033002/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_devtools_manager.py:1:
# Copyright 2014 The Chromium Authors. All rights reserved.
On 2015/09/14 20:12:04, nednguyen wrote:
> 2015

Done.

https://codereview.chromium.org/1338033002/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_devtools_manager.py:28:
def RegisterDevToolsClient(devtools_client_backend, platform_backend):
On 2015/09/14 20:12:04, nednguyen wrote:
> Can you add some comment about this should only be called from
> DevtoolClientBackend?
> I know no good way to enforce this, so if you have any better idea, it would
be
> great.

Done.

https://codereview.chromium.org/1338033002/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_devtools_manager.py:60:
def GetNonStaleDevToolsClients(platform_backend):
On 2015/09/14 20:12:04, nednguyen wrote:
> GetActiveDevtoolsClient

Done.

[Zhen Wang, 2015-09-14 20:24:54]

The CQ bit was checked by zhenw@chromium.org

[Zhen Wang, 2015-09-14 20:24:55]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/1338033002/#ps20001
(title: "review fix")

[commit-bot: I haz the power, 2015-09-14 20:26:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1338033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1338033002/20001

[commit-bot: I haz the power, 2015-09-14 22:15:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-14 22:16:02]

Patchset 2 (id:??) landed as
https://crrev.com/cbecca3af4042fbf593dead4c12cfdd22cfd2310
Cr-Commit-Position: refs/heads/master@{#348740}

[Zhen Wang, 2015-09-15 00:02:57]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1343883002/ by zhenw@chromium.org.

The reason for reverting is: This CL fails on mojo perf bots. For Chrome,
Telemetry waits for Chrome for the devtools port number. But for mojo, telemetry
gives the port number to mandoline. Revert for now, will work on a fix.

See https://code.google.com/p/chromium/issues/detail?id=531755.

[commit-bot: I haz the power, 2015-09-23 12:38:05]

Patchset 2 (id:??) landed as
https://crrev.com/cbecca3af4042fbf593dead4c12cfdd22cfd2310
Cr-Commit-Position: refs/heads/master@{#348740}