Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1441)

Unified Diff: chrome/browser/task_management/providers/web_contents/renderer_task.h

Issue 1338023002: Refactor TaskManager's favicon retrieval approach (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/task_management/providers/web_contents/renderer_task.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_management/providers/web_contents/renderer_task.h
diff --git a/chrome/browser/task_management/providers/web_contents/renderer_task.h b/chrome/browser/task_management/providers/web_contents/renderer_task.h
index c0cbe0feeab2577f91e7e7f1f15d0984387c0de3..3ab9faec67cc1341e434f3b41d5c39b4670299e1 100644
--- a/chrome/browser/task_management/providers/web_contents/renderer_task.h
+++ b/chrome/browser/task_management/providers/web_contents/renderer_task.h
@@ -6,6 +6,7 @@
#define CHROME_BROWSER_TASK_MANAGEMENT_PROVIDERS_WEB_CONTENTS_RENDERER_TASK_H_
#include "chrome/browser/task_management/providers/task.h"
+#include "components/favicon/core/favicon_driver_observer.h"
#include "content/public/browser/navigation_entry.h"
class ProcessResourceUsage;
@@ -19,7 +20,8 @@ namespace task_management {
// Defines an abstract base class for various types of renderer process tasks
// such as background contents, tab contents, ... etc.
-class RendererTask : public Task {
+class RendererTask : public Task,
+ public favicon::FaviconDriverObserver {
public:
RendererTask(const base::string16& title,
const gfx::ImageSkia* icon,
@@ -34,8 +36,8 @@ class RendererTask : public Task {
virtual void UpdateTitle() = 0;
// An abstract method that will be called when the event
- // WebContentsObserver::DocumentOnLoadCompletedInMainFrame() occurs, so that
- // concrete tasks can update their favicons.
+ // FaviconDriverObserver::OnFaviconUpdated() occurs, so that concrete tasks
+ // can update their favicons.
virtual void UpdateFavicon() = 0;
// task_management::Task:
@@ -50,6 +52,11 @@ class RendererTask : public Task {
bool ReportsWebCacheStats() const override;
blink::WebCache::ResourceTypeStats GetWebCacheStats() const override;
+ // favicon::FaviconDriverObserver:
+ void OnFaviconAvailable(const gfx::Image& image) override;
+ void OnFaviconUpdated(favicon::FaviconDriver* favicon_driver,
+ bool icon_url_changed) override;
+
protected:
// Returns the title of the given |web_contents|.
static base::string16 GetTitleFromWebContents(
« no previous file with comments | « no previous file | chrome/browser/task_management/providers/web_contents/renderer_task.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698