Fix some typos in GN documentation.

Fix some typos in GN documentation.

Committed: https://crrev.com/91e3ca5ba9866da089ef6b37fdba3d84f7e51602
Cr-Commit-Position: refs/heads/master@{#348497}

[eroman, 2015-09-11 20:37:06]

eroman@chromium.org changed reviewers:
+ brettw@chromium.org

[eroman, 2015-09-11 20:37:06]

https://codereview.chromium.org/1338003005/diff/1/tools/gn/docs/language.md
File tools/gn/docs/language.md (left):

https://codereview.chromium.org/1338003005/diff/1/tools/gn/docs/language.md#o...
tools/gn/docs/language.md:59: set_sources_assignment_filter` and `gn help
patterns` for more.
(gn help patterns doesn't exist)

https://codereview.chromium.org/1338003005/diff/1/tools/gn/docs/language.md#o...
tools/gn/docs/language.md:383: * `test`: Generates an executable but annotates
it as a test.
"test" does not appear to be a built-in (rather is a chrome-specific template).

https://codereview.chromium.org/1338003005/diff/1/tools/gn/docs/language.md
File tools/gn/docs/language.md (right):

https://codereview.chromium.org/1338003005/diff/1/tools/gn/docs/language.md#n...
tools/gn/docs/language.md:674: They are like simple regular expressions. See `gn
help set_sources_assignment_filter` for more.
Is this right? Do I need to wrap this?

[brettw, 2015-09-11 21:03:14]

thanks, lgtm

https://codereview.chromium.org/1338003005/diff/1/tools/gn/docs/language.md
File tools/gn/docs/language.md (left):

https://codereview.chromium.org/1338003005/diff/1/tools/gn/docs/language.md#o...
tools/gn/docs/language.md:59: set_sources_assignment_filter` and `gn help
patterns` for more.
On 2015/09/11 20:37:06, eroman wrote:
> (gn help patterns doesn't exist)

Ah, this should be `gn help label_pattern` instead.

https://codereview.chromium.org/1338003005/diff/1/tools/gn/docs/language.md#o...
tools/gn/docs/language.md:383: * `test`: Generates an executable but annotates
it as a test.
Yeah, I moved this a while ago to being a template.

https://codereview.chromium.org/1338003005/diff/1/tools/gn/docs/language.md
File tools/gn/docs/language.md (right):

https://codereview.chromium.org/1338003005/diff/1/tools/gn/docs/language.md#n...
tools/gn/docs/language.md:674: They are like simple regular expressions. See `gn
help set_sources_assignment_filter` for more.
On 2015/09/11 20:37:06, eroman wrote:
> Is this right? Do I need to wrap this?

label_pattern instead.

[eroman, 2015-09-11 21:08:11]

BTW the documentation was a pleasure to read through!

I set up a project using GN over the weekend and really liked it :)

https://codereview.chromium.org/1338003005/diff/1/tools/gn/docs/language.md
File tools/gn/docs/language.md (left):

https://codereview.chromium.org/1338003005/diff/1/tools/gn/docs/language.md#o...
tools/gn/docs/language.md:59: set_sources_assignment_filter` and `gn help
patterns` for more.
On 2015/09/11 21:03:14, brettw wrote:
> On 2015/09/11 20:37:06, eroman wrote:
> > (gn help patterns doesn't exist)
> 
> Ah, this should be `gn help label_pattern` instead.

Done.

[brettw, 2015-09-11 21:09:18]

On 2015/09/11 21:08:11, eroman wrote:
> BTW the documentation was a pleasure to read through!
> 
> I set up a project using GN over the weekend and really liked it :)

Cool, it's actually pretty hard to set up a new build. I was hoping it would be
easier but Chrome requires so much customization, it means that even simple
things need to be build-defined.

[eroman, 2015-09-11 21:12:19]

The CQ bit was checked by eroman@chromium.org

[eroman, 2015-09-11 21:12:19]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1338003005/#ps40001
(title: "redo a line split")

[commit-bot: I haz the power, 2015-09-11 21:13:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1338003005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1338003005/40001

[commit-bot: I haz the power, 2015-09-11 22:34:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-11 22:35:52]

Patchset 3 (id:??) landed as
https://crrev.com/91e3ca5ba9866da089ef6b37fdba3d84f7e51602
Cr-Commit-Position: refs/heads/master@{#348497}

[commit-bot: I haz the power, 2015-09-23 12:26:48]

Patchset 3 (id:??) landed as
https://crrev.com/91e3ca5ba9866da089ef6b37fdba3d84f7e51602
Cr-Commit-Position: refs/heads/master@{#348497}