Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1337993006: [MD settings] adding open this page text (Closed)

Created:
5 years, 3 months ago by dschuyler
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang, stevenjb
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] adding open this page text This CL adds label text for setting the homepage in the appearance settings (to be used in a near future CL). BUG=531786 Committed: https://crrev.com/346fdb4167d3296830fc3c2b94fce12fc0f59702 Cr-Commit-Position: refs/heads/master@{#348990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
dschuyler
5 years, 3 months ago (2015-09-15 17:57:39 UTC) #2
stevenjb
lgtm
5 years, 3 months ago (2015-09-15 18:23:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337993006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337993006/1
5 years, 3 months ago (2015-09-15 18:31:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/99982)
5 years, 3 months ago (2015-09-15 18:54:00 UTC) #7
dschuyler
5 years, 3 months ago (2015-09-15 19:44:21 UTC) #9
Lei Zhang
lgtm
5 years, 3 months ago (2015-09-15 20:24:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337993006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337993006/1
5 years, 3 months ago (2015-09-15 20:52:22 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 20:58:42 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/346fdb4167d3296830fc3c2b94fce12fc0f59702 Cr-Commit-Position: refs/heads/master@{#348990}
5 years, 3 months ago (2015-09-15 20:59:27 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:49:28 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/346fdb4167d3296830fc3c2b94fce12fc0f59702
Cr-Commit-Position: refs/heads/master@{#348990}

Powered by Google App Engine
This is Rietveld 408576698