Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1337993005: [runtime] Replace the EQUALS builtin with proper Object::Equals. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Replace the EQUALS builtin with proper Object::Equals. Move the implementation of the Abstract Equality Comparison to the runtime and thereby remove the EQUALS dispatcher builtin. Also remove the various runtime entry points that were only used to support the EQUALS builtin. Now the Abstract Equality Comparison is also using the correct ToPrimitive implementation, which properly supports @@toPrimitive. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg,v8_linux_nosnap_dbg R=mstarzinger@chromium.org BUG=v8:4307 LOG=n Committed: https://crrev.com/54bab695f5de5bf5948c5b50b217628a00d60f91 Cr-Commit-Position: refs/heads/master@{#30747}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Michi's nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -223 lines) Patch
M src/api.cc View 1 chunk +1 line, -15 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +13 lines, -17 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +13 lines, -17 lines 0 comments Download
M src/contexts.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +7 lines, -11 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +13 lines, -17 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +13 lines, -17 lines 0 comments Download
M src/objects.h View 1 4 chunks +8 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +109 lines, -8 lines 0 comments Download
M src/objects-inl.h View 3 chunks +15 lines, -3 lines 0 comments Download
M src/runtime.js View 2 chunks +0 lines, -63 lines 0 comments Download
M src/runtime/runtime.h View 3 chunks +1 line, -3 lines 0 comments Download
M src/runtime/runtime-numbers.cc View 3 chunks +2 lines, -21 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/runtime/runtime-simd.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +7 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Benedikt Meurer
5 years, 3 months ago (2015-09-15 11:29:25 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337993005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337993005/1
5 years, 3 months ago (2015-09-15 11:30:10 UTC) #3
Benedikt Meurer
Hey Michi, The next weird builtin gone. Please take a look. Thanks, Benedikt
5 years, 3 months ago (2015-09-15 11:30:17 UTC) #4
Michael Starzinger
LGTM. https://codereview.chromium.org/1337993005/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/1337993005/diff/1/src/objects.h#newcode9109 src/objects.h:9109: DECLARE_CAST(Oddball) nit: Move the caster down so that ...
5 years, 3 months ago (2015-09-15 11:52:56 UTC) #5
Benedikt Meurer
https://codereview.chromium.org/1337993005/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/1337993005/diff/1/src/objects.h#newcode9109 src/objects.h:9109: DECLARE_CAST(Oddball) On 2015/09/15 11:52:56, Michael Starzinger wrote: > nit: ...
5 years, 3 months ago (2015-09-15 11:54:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337993005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337993005/20001
5 years, 3 months ago (2015-09-15 11:54:34 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-15 13:14:43 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 13:14:58 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/54bab695f5de5bf5948c5b50b217628a00d60f91
Cr-Commit-Position: refs/heads/master@{#30747}

Powered by Google App Engine
This is Rietveld 408576698