Issue 1337993004: fixes #315, order of libraries in the HTML file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1337993004: fixes #315, order of libraries in the HTML file (Closed)

Created:
5 years, 3 months ago by Jennifer Messerly

Modified:
5 years, 3 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

fixes #315, order of libraries in the HTML file the lesson here is never use .importedLibraries ... we might want to change it in analyzer to use LinkedHashSet ... R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/0b588c926ce03638a0919978af4ff29b785304b1

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	lib/src/compiler.dart	View		2 chunks	+5 lines, -4 lines	1 comment	Download
	M	test/codegen/expect/sunflower/sunflower.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jennifer Messerly

https://codereview.chromium.org/1337993004/diff/1/lib/src/compiler.dart File lib/src/compiler.dart (right): https://codereview.chromium.org/1337993004/diff/1/lib/src/compiler.dart#newcode268 lib/src/compiler.dart:268: void _collectLibraries(LibraryElement lib, LinkedHashSet<Uri> loaded) { our own ordered ...

5 years, 3 months ago (2015-09-15 00:32:59 UTC) #2

Jennifer Messerly

5 years, 3 months ago (2015-09-15 16:13:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0b588c926ce03638a0919978af4ff29b785304b1 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages