Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 1337963002: base: Update comment about use of std::numeric_limits. (Closed)

Created:
5 years, 3 months ago by tfarina
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Update comment about use of std::numeric_limits. Mention that is also possible to use the (U)INTx_{MIN,MAX} macros from stdint.h as well, when numeric_limits introduce static initializers. See chromium-dev discussion in https://groups.google.com/a/chromium.org/d/topic/chromium-dev/Bvd9QU5pY9Q/discussion for more details. BUG=138542 R=thestig@chromium.org Committed: https://crrev.com/60801fe669ada7f139c9a4d1e606a925d1b4355e Cr-Commit-Position: refs/heads/master@{#348528}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M base/basictypes.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
tfarina
5 years, 3 months ago (2015-09-11 17:16:54 UTC) #1
Lei Zhang
lgtm
5 years, 3 months ago (2015-09-11 20:43:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337963002/1
5 years, 3 months ago (2015-09-11 20:45:41 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/67910)
5 years, 3 months ago (2015-09-11 23:35:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337963002/1
5 years, 3 months ago (2015-09-11 23:39:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/68018)
5 years, 3 months ago (2015-09-12 03:27:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337963002/1
5 years, 3 months ago (2015-09-12 03:33:34 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-12 13:00:59 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/60801fe669ada7f139c9a4d1e606a925d1b4355e Cr-Commit-Position: refs/heads/master@{#348528}
5 years, 3 months ago (2015-09-12 13:02:13 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:27:59 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60801fe669ada7f139c9a4d1e606a925d1b4355e
Cr-Commit-Position: refs/heads/master@{#348528}

Powered by Google App Engine
This is Rietveld 408576698