Fix initialization order (setup) for JSArrayBuffer objects.

Fix initialization order (setup) for JSArrayBuffer objects.

BUG=chromium:531322
LOG=N
R=jochen@chromium.org

Committed: https://crrev.com/cb621e2e2cce9770f0ede9cb3d4d1886a6e199f0
Cr-Commit-Position: refs/heads/master@{#30713}

[Michael Lippautz, 2015-09-14 10:35:29]

mlippautz@chromium.org changed reviewers:
+ jochen@chromium.org

[Michael Lippautz, 2015-09-14 10:35:30]

https://codereview.chromium.org/1337943005/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1337943005/diff/1/src/objects.cc#newcode16199
src/objects.cc:16199: Handle<Object> byte_length =
Not sure about this one, but I guess we should properly set the length in case
we add a backing store?

[jochen (gone - plz use gerrit), 2015-09-14 10:41:55]

lgtm with setting the length in materialize removed

https://codereview.chromium.org/1337943005/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1337943005/diff/1/src/objects.cc#newcode16199
src/objects.cc:16199: Handle<Object> byte_length =
On 2015/09/14 at 10:35:30, Michael Lippautz wrote:
> Not sure about this one, but I guess we should properly set the length in case
we add a backing store?

the length should already be set correctly at that point

[Michael Lippautz, 2015-09-14 11:03:11]

https://codereview.chromium.org/1337943005/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1337943005/diff/1/src/objects.cc#newcode16199
src/objects.cc:16199: Handle<Object> byte_length =
On 2015/09/14 10:41:55, jochen wrote:
> On 2015/09/14 at 10:35:30, Michael Lippautz wrote:
> > Not sure about this one, but I guess we should properly set the length in
case
> we add a backing store?
> 
> the length should already be set correctly at that point

Replaced with a DCHECK as discussed offline.

[Michael Lippautz, 2015-09-14 11:03:17]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-14 11:03:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1337943005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1337943005/20001

[commit-bot: I haz the power, 2015-09-14 11:05:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 11:05:04]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[jochen (gone - plz use gerrit), 2015-09-14 11:06:24]

https://codereview.chromium.org/1337943005/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1337943005/diff/20001/src/objects.cc#newcode1...
src/objects.cc:16199: DCHECK(buffer->byte_length->IsHeapNumber() &&
can also be a smi, no?

[Michael Lippautz, 2015-09-14 11:09:45]

https://codereview.chromium.org/1337943005/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1337943005/diff/20001/src/objects.cc#newcode1...
src/objects.cc:16199: DCHECK(buffer->byte_length->IsHeapNumber() &&
On 2015/09/14 11:06:24, jochen wrote:
> can also be a smi, no?

Yes, figured this out after starting the dry run...

[Michael Lippautz, 2015-09-14 11:26:51]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-14 11:27:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1337943005/20002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1337943005/20002

[commit-bot: I haz the power, 2015-09-14 11:50:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 11:50:07]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2015-09-14 11:57:09]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2015-09-14 11:57:09]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1337943005/#ps20002
(title: "Fix DCHECK for bytelength and compilation")

[commit-bot: I haz the power, 2015-09-14 11:57:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1337943005/20002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1337943005/20002

[commit-bot: I haz the power, 2015-09-14 11:59:19]

Committed patchset #3 (id:20002)

[commit-bot: I haz the power, 2015-09-14 11:59:31]

Patchset 3 (id:??) landed as
https://crrev.com/cb621e2e2cce9770f0ede9cb3d4d1886a6e199f0
Cr-Commit-Position: refs/heads/master@{#30713}