Chromium Code Reviews

Issue 1337933002: Oilpan: fix build after r202130. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
Reviewers:
oilpan-reviews, haraken, yosin
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r202130. The Blink GC plugin is syntactic, requiring GCed fields to literally appear within the trace() method body. Once that don't are assumed not to have been traced. Which prevents the use of an accessor, like r202130 introduced. TBR=oilpan-reviews,yosin BUG=513568 NOTRY=true Committed: https://crrev.com/dac6dd3eac24e901b01d2e6f0fb9fa015f8f1b82 git-svn-id: svn://svn.chromium.org/blink/trunk@202137 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+1 line, -1 line)
M Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 8 (3 generated)
sof
5 years, 3 months ago (2015-09-11 14:40:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337933002/1
5 years, 3 months ago (2015-09-11 14:40:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202137
5 years, 3 months ago (2015-09-11 14:45:30 UTC) #6
haraken
LGTM
5 years, 3 months ago (2015-09-11 15:38:43 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:22:22 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dac6dd3eac24e901b01d2e6f0fb9fa015f8f1b82

Powered by Google App Engine