Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1337923002: Replace use Range::selectNodeContents() with EphemeralRange counterpart. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replace use Range::selectNodeContents() with EphemeralRange counterpart. Switch to EphemeralRange::rangeOfContents() and avoid a Range allocation in the process. R=haraken BUG=388681 Committed: https://crrev.com/c7eb34811c314fceb1f826b4799da37bfcbaaf25 git-svn-id: svn://svn.chromium.org/blink/trunk@202139 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sof
please take a look. Split out from https://codereview.chromium.org/1335573004/ ps#3, as suggested.
5 years, 3 months ago (2015-09-11 13:43:54 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-09-11 13:44:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337923002/1
5 years, 3 months ago (2015-09-11 13:45:24 UTC) #5
yosin_UTC9
On 2015/09/11 13:43:54, sof wrote: > please take a look. > > Split out from ...
5 years, 3 months ago (2015-09-11 14:20:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202139
5 years, 3 months ago (2015-09-11 15:26:09 UTC) #7
sof
On 2015/09/11 14:20:20, Yosi_UTC9 wrote: > On 2015/09/11 13:43:54, sof wrote: > > please take ...
5 years, 3 months ago (2015-09-11 15:29:10 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:22:40 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7eb34811c314fceb1f826b4799da37bfcbaaf25

Powered by Google App Engine
This is Rietveld 408576698