permissions: remove PermissionQueueController and introduce PermissionInfoBarManager

chrome/browser/permissions/permission_context_base_unittest.cc

Index: chrome/browser/permissions/permission_context_base_unittest.cc
diff --git a/chrome/browser/permissions/permission_context_base_unittest.cc b/chrome/browser/permissions/permission_context_base_unittest.cc
index 3e672099546186d4a3ad21d8c9283c85d7a81367..9fc68e2d754c67ffb95d1eae9f87911f48ed7449 100644
--- a/chrome/browser/permissions/permission_context_base_unittest.cc
+++ b/chrome/browser/permissions/permission_context_base_unittest.cc
@@ -8,7 +8,7 @@
 #include "base/command_line.h"
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 #include "chrome/browser/infobars/infobar_service.h"
-#include "chrome/browser/permissions/permission_queue_controller.h"
+#include "chrome/browser/permissions/permission_infobar_manager.h"
 #include "chrome/browser/permissions/permission_request_id.h"
 #include "chrome/browser/ui/website_settings/permission_bubble_manager.h"
 #include "chrome/common/chrome_switches.h"
@@ -34,10 +34,6 @@ class TestPermissionContext : public PermissionContextBase {
 
   ~TestPermissionContext() override {}
 
-  PermissionQueueController* GetInfoBarController() {
-    return GetQueueController();
-  }
-
   bool permission_granted() {
     return permission_granted_;
   }
@@ -77,13 +73,12 @@ class PermissionContextBaseTests : public ChromeRenderViewHostTestHarness {
   PermissionContextBaseTests() {}
 
   // Accept or dismiss the permission bubble or infobar.
-  void RespondToPermission(TestPermissionContext* context,
-                           const PermissionRequestID& id,
-                           const GURL& url,
+  void RespondToPermission(const PermissionRequestID& request,
                            bool accept) {
     if (!PermissionBubbleManager::Enabled()) {
-      context->GetInfoBarController()->OnPermissionSet(
-          id, url, url, accept, accept);
+      PermissionInfoBarManager* manager =
+          PermissionInfoBarManager::FromWebContents(web_contents());
+      manager->CancelInfoBarRequest(request);

[mlamouri (slow - plz ping), 2015/09/28 13:30:14]

That sounds odd. You don't actually use |accept|. Why?

[Lalit Maganti, 2015/09/28 15:32:38]

I have no clue. Will look into it.

       return;
     }
 
@@ -111,7 +106,7 @@ class PermissionContextBaseTests : public ChromeRenderViewHostTestHarness {
         base::Bind(&TestPermissionContext::TrackPermissionDecision,
                    base::Unretained(&permission_context)));
 
-    RespondToPermission(&permission_context, id, url, true);
+    RespondToPermission(id, true);
     EXPECT_TRUE(permission_context.permission_set());
     EXPECT_TRUE(permission_context.permission_granted());
     EXPECT_TRUE(permission_context.tab_context_updated());
@@ -141,7 +136,7 @@ class PermissionContextBaseTests : public ChromeRenderViewHostTestHarness {
         base::Bind(&TestPermissionContext::TrackPermissionDecision,
                    base::Unretained(&permission_context)));
 
-    RespondToPermission(&permission_context, id, url, false);
+    RespondToPermission(id, false);
     EXPECT_TRUE(permission_context.permission_set());
     EXPECT_FALSE(permission_context.permission_granted());
     EXPECT_TRUE(permission_context.tab_context_updated());
@@ -200,7 +195,7 @@ class PermissionContextBaseTests : public ChromeRenderViewHostTestHarness {
         base::Bind(&TestPermissionContext::TrackPermissionDecision,
                    base::Unretained(&permission_context)));
 
-    RespondToPermission(&permission_context, id, url, true);
+    RespondToPermission(id, true);
     EXPECT_TRUE(permission_context.permission_set());
     EXPECT_TRUE(permission_context.permission_granted());
     EXPECT_TRUE(permission_context.tab_context_updated());