permissions: remove PermissionQueueController and introduce PermissionInfoBarManager

chrome/browser/geolocation/geolocation_permission_context_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/geolocation/geolocation_permission_context.h"
 
 #include <set>
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/containers/hash_tables.h"
 #include "base/gtest_prod_util.h"
 #include "base/id_map.h"
 #include "base/memory/scoped_vector.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/test/simple_test_clock.h"
 #include "base/time/clock.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
 #include "chrome/browser/geolocation/geolocation_permission_context_factory.h"
 #include "chrome/browser/infobars/infobar_service.h"
+#include "chrome/browser/permissions/permission_infobar_manager.h"
 #include "chrome/browser/permissions/permission_request_id.h"
 #include "chrome/browser/ui/website_settings/mock_permission_bubble_view.h"
 #include "chrome/browser/ui/website_settings/permission_bubble_manager.h"
 #include "chrome/browser/ui/website_settings/permission_bubble_request.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "components/infobars/core/confirm_infobar_delegate.h"
 #include "components/infobars/core/infobar.h"
@@ skipping 84 matching lines @@
   void TearDown() override;
 
   PermissionRequestID RequestID(int request_id);
   PermissionRequestID RequestIDForTab(int tab, int request_id);
   InfoBarService* infobar_service() {
     return InfoBarService::FromWebContents(web_contents());
   }
   InfoBarService* infobar_service_for_tab(int tab) {
     return InfoBarService::FromWebContents(extra_tabs_[tab]);
   }
+  PermissionInfoBarManager* infobar_manager() {
+    return PermissionInfoBarManager::FromWebContents(web_contents());
+  }
+  PermissionInfoBarManager* infobar_manager_for_tab(int tab) {
+    return PermissionInfoBarManager::FromWebContents(extra_tabs_[tab]);
+  }
 
   void RequestGeolocationPermission(content::WebContents* web_contents,
                                     const PermissionRequestID& id,
                                     const GURL& requesting_frame,
                                     bool user_gesture);
 
   void PermissionResponse(const PermissionRequestID& id,
                           ContentSetting content_setting);
   void CheckPermissionMessageSent(int request_id, bool allowed);
   void CheckPermissionMessageSentForTab(int tab, int request_id, bool allowed);
   void CheckPermissionMessageSentInternal(MockRenderProcessHost* process,
                                           int request_id,
                                           bool allowed);
   void AddNewTab(const GURL& url);
   void CheckTabContentsState(const GURL& requesting_frame,
                              ContentSetting expected_content_setting);
   size_t GetBubblesQueueSize(PermissionBubbleManager* manager);
   void AcceptBubble(PermissionBubbleManager* manager);
   void DenyBubble(PermissionBubbleManager* manager);
   void CloseBubble(PermissionBubbleManager* manager);
   void BubbleManagerDocumentLoadCompleted();
   void BubbleManagerDocumentLoadCompleted(content::WebContents* web_contents);
   ContentSetting GetGeolocationContentSetting(GURL frame_0, GURL frame_1);
   bool BubbleEnabled() const;
   size_t GetNumberOfPrompts();
   void AcceptPrompt();
   base::string16 GetPromptText();
 
+  bool IsInfoBarShowPending(PermissionInfoBarManager* manager) const;
+  void ShowNextQueuedInfoBar(PermissionInfoBarManager* manager);
+
   // owned by the browser context
   GeolocationPermissionContext* geolocation_permission_context_;
   ClosedInfoBarTracker closed_infobar_tracker_;
   ScopedVector<content::WebContents> extra_tabs_;
 
   // A map between renderer child id and a pair represending the bridge id and
   // whether the requested permission was allowed.
   base::hash_map<int, std::pair<int, bool> > responses_;
 };
 
@@ skipping 64 matching lines @@
       url, content::Referrer(), ui::PAGE_TRANSITION_TYPED, std::string());
   content::NavigationEntry* entry = new_tab->GetController().GetPendingEntry();
   content::RenderFrameHostTester::For(new_tab->GetMainFrame())
       ->SendNavigate(extra_tabs_.size() + 1, entry->GetUniqueID(), true, url);
 
   // Set up required helpers, and make this be as "tabby" as the code requires.
 #if defined(ENABLE_EXTENSIONS)
   extensions::SetViewType(new_tab, extensions::VIEW_TYPE_TAB_CONTENTS);
 #endif
   InfoBarService::CreateForWebContents(new_tab);
+  PermissionInfoBarManager::CreateForWebContents(new_tab);
   if (BubbleEnabled()) {
     PermissionBubbleManager::CreateForWebContents(new_tab);
     PermissionBubbleManager* permission_bubble_manager =
         PermissionBubbleManager::FromWebContents(new_tab);
     MockPermissionBubbleView::SetFactory(permission_bubble_manager, false);
     permission_bubble_manager->DisplayPendingRequests();
   }
 
   extra_tabs_.push_back(new_tab);
 }
@@ skipping 15 matching lines @@
 }
 
 void GeolocationPermissionContextTests::SetUp() {
   ChromeRenderViewHostTestHarness::SetUp();
 
   // Set up required helpers, and make this be as "tabby" as the code requires.
 #if defined(ENABLE_EXTENSIONS)
   extensions::SetViewType(web_contents(), extensions::VIEW_TYPE_TAB_CONTENTS);
 #endif
   InfoBarService::CreateForWebContents(web_contents());
+  PermissionInfoBarManager::CreateForWebContents(web_contents());
   TabSpecificContentSettings::CreateForWebContents(web_contents());
   geolocation_permission_context_ =
       GeolocationPermissionContextFactory::GetForProfile(profile());
 #if defined(OS_ANDROID)
   static_cast<GeolocationPermissionContextAndroid*>(
       geolocation_permission_context_)
       ->SetLocationSettingsForTesting(
           scoped_ptr<LocationSettings>(new MockLocationSettings()));
   MockLocationSettings::SetLocationStatus(true, true);
 #endif
@@ skipping 83 matching lines @@
     PermissionBubbleManager* manager =
         PermissionBubbleManager::FromWebContents(web_contents());
     return manager->requests_.front()->GetMessageText();
   }
   infobars::InfoBar* infobar = infobar_service()->infobar_at(0);
   ConfirmInfoBarDelegate* infobar_delegate =
       infobar->delegate()->AsConfirmInfoBarDelegate();
   return infobar_delegate->GetMessageText();
 }
 
+bool GeolocationPermissionContextTests::IsInfoBarShowPending(
+    PermissionInfoBarManager* manager) const {
+  return manager->is_show_pending_;
+}
+
+void GeolocationPermissionContextTests::ShowNextQueuedInfoBar(
+    PermissionInfoBarManager* manager) {
+  manager->ShowNextQueuedRequest();
+}
+
 // Tests ----------------------------------------------------------------------
 
 TEST_F(GeolocationPermissionContextTests, SinglePermissionInfobar) {
   if (BubbleEnabled()) return;
 
   GURL requesting_frame("http://www.example.com/geolocation");
   NavigateAndCommit(requesting_frame);
   EXPECT_EQ(0U, infobar_service()->infobar_count());
   RequestGeolocationPermission(
       web_contents(), RequestID(0), requesting_frame, true);
@@ skipping 101 matching lines @@
   AcceptPrompt();
   CheckTabContentsState(requesting_frame_0, CONTENT_SETTING_ALLOW);
   CheckPermissionMessageSent(0, true);
 
   if (!BubbleEnabled()) {
     infobars::InfoBar* infobar_0 = infobar_service()->infobar_at(0);
     infobar_service()->RemoveInfoBar(infobar_0);
     EXPECT_EQ(1U, closed_infobar_tracker_.size());
     EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_0));
     closed_infobar_tracker_.Clear();
+
+    // Make the next request appear after having checked that it was posted
+    // to the event loop.
+    ASSERT_TRUE(IsInfoBarShowPending(infobar_manager()));
+    ShowNextQueuedInfoBar(infobar_manager());
   }
 
   // Now we should have a new infobar for the second frame.
   ASSERT_EQ(1U, GetNumberOfPrompts());
   base::string16 text_1 = GetPromptText();
 
   // Check that the messages differ.
   EXPECT_NE(text_0, text_1);
 
   // Cancel (block) this frame.
@@ skipping 43 matching lines @@
 
   // Cleanup.
   if (!BubbleEnabled()) {
     infobars::InfoBar* infobar = infobar_service()->infobar_at(0);
     infobar_service()->RemoveInfoBar(infobar);
     EXPECT_EQ(1U, closed_infobar_tracker_.size());
     EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar));
   }
 }
 
-TEST_F(GeolocationPermissionContextTests, PermissionForFileScheme) {
-  // TODO(felt): The bubble is rejecting file:// permission requests.
-  // Fix and enable this test. crbug.com/444047
-  if (BubbleEnabled()) return;
-
+// TODO(felt): The bubble and (recently) the infobar are rejecting file://
+// permission requests. Fix and enable this test. crbug.com/444047
+TEST_F(GeolocationPermissionContextTests, DISABLED_PermissionForFileScheme) {
   GURL requesting_frame("file://example/geolocation.html");
   NavigateAndCommit(requesting_frame);
   if (BubbleEnabled()) BubbleManagerDocumentLoadCompleted();
 
   // Check permission is requested.
   ASSERT_EQ(0U, GetNumberOfPrompts());
   RequestGeolocationPermission(
       web_contents(), RequestID(0), requesting_frame, true);
   EXPECT_EQ(1U, GetNumberOfPrompts());
 
@@ skipping 33 matching lines @@
   ASSERT_FALSE(text_0.empty());
 
   // Simulate the frame going away; the request should be removed.
   if (BubbleEnabled()) {
     PermissionBubbleManager* manager =
         PermissionBubbleManager::FromWebContents(web_contents());
     CloseBubble(manager);
   } else {
     geolocation_permission_context_->CancelPermissionRequest(web_contents(),
         RequestID(0));
+
+    // Make the next request appear after having checked that it was posted
+    // to the event loop.
+    ASSERT_TRUE(IsInfoBarShowPending(infobar_manager()));
+    ShowNextQueuedInfoBar(infobar_manager());
   }
 
   // Check that the next pending request is created correctly.
   base::string16 text_1 = GetPromptText();
   EXPECT_NE(text_0, text_1);
 
   // Allow this frame and check that it worked.
   AcceptPrompt();
   CheckTabContentsState(frame_1, CONTENT_SETTING_ALLOW);
   CheckPermissionMessageSent(1, true);
@@ skipping 57 matching lines @@
   // Accept the permission in tab A0.
   if (BubbleEnabled()) {
     AcceptBubble(manager_a0);
   } else {
     infobars::InfoBar* infobar_a0 = infobar_service()->infobar_at(0);
     ConfirmInfoBarDelegate* infobar_delegate_a0 =
         infobar_a0->delegate()->AsConfirmInfoBarDelegate();
     ASSERT_TRUE(infobar_delegate_a0);
     infobar_delegate_a0->Accept();
     infobar_service()->RemoveInfoBar(infobar_a0);
-    EXPECT_EQ(2U, closed_infobar_tracker_.size());
+    EXPECT_EQ(1U, closed_infobar_tracker_.size());
     EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_a0));
   }
   CheckPermissionMessageSent(0, true);
-  // Because they're the same origin, this will cause tab A1's infobar to
-  // disappear. It does not cause the bubble to disappear: crbug.com/443013.
-  // TODO(felt): Update this test when the bubble's behavior is changed.
+
+  // Because they're the same origin, tab_a1's bubble/infobar should disappear.
+  // In the past, infobar used to disappear and bubble did not.
+  // Now both have a consistent behviour (albiet broken) of not removing
+  // the bubble/infobar: see crbug.com/443013.
+  // TODO(felt): Update this test when this behavior is changed.
   if (BubbleEnabled())
     ASSERT_EQ(1U, GetBubblesQueueSize(manager_a1));
   else
-    CheckPermissionMessageSentForTab(1, 0, true);
+    EXPECT_EQ(1U, infobar_service_for_tab(1)->infobar_count());
 
   // Either way, tab B should still have a pending permission request.
   if (BubbleEnabled())
     ASSERT_EQ(1U, GetBubblesQueueSize(manager_b));
   else
     ASSERT_EQ(1U, infobar_service_for_tab(0)->infobar_count());
 }
 
 TEST_F(GeolocationPermissionContextTests, QueuedOriginMultipleTabs) {
   GURL url_a("http://www.example.com/geolocation");
@@ skipping 28 matching lines @@
   // Accept the first request in tab A1.
   if (BubbleEnabled()) {
     AcceptBubble(manager_a1);
   } else {
     infobars::InfoBar* infobar_a1 = infobar_service_for_tab(0)->infobar_at(0);
     ConfirmInfoBarDelegate* infobar_delegate_a1 =
         infobar_a1->delegate()->AsConfirmInfoBarDelegate();
     ASSERT_TRUE(infobar_delegate_a1);
     infobar_delegate_a1->Accept();
     infobar_service_for_tab(0)->RemoveInfoBar(infobar_a1);
-    EXPECT_EQ(2U, closed_infobar_tracker_.size());
+    EXPECT_EQ(1U, closed_infobar_tracker_.size());
     EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_a1));
+
+    // Make the next request appear after having checked that it was posted
+    // to the event loop.
+    ASSERT_TRUE(IsInfoBarShowPending(infobar_manager_for_tab(0)));
+    ShowNextQueuedInfoBar(infobar_manager_for_tab(0));
   }
   CheckPermissionMessageSentForTab(0, 0, true);
 
-  // Because they're the same origin, this will cause tab A0's infobar to
-  // disappear. It does not cause the bubble to disappear: crbug.com/443013.
-  // TODO(felt): Update this test when the bubble's behavior is changed.
-  if (BubbleEnabled()) {
+  // Because they're the same origin, tab_a0's bubble/infobar should disappear.
+  // In the past, infobar used to disappear and bubble did not.
+  // Now both have a consistent behviour (albiet broken) of not removing
+  // the bubble/infobar: see crbug.com/443013.
+  // TODO(felt): Update this test when this behavior is changed.
+  if (BubbleEnabled())
     EXPECT_EQ(1U, GetBubblesQueueSize(manager_a0));
-  } else {
-    EXPECT_EQ(0U, infobar_service()->infobar_count());
-    CheckPermissionMessageSent(0, true);
-  }
+  else
+    EXPECT_EQ(1U, infobar_service()->infobar_count());
 
   // The second request should now be visible in tab A1.
   if (BubbleEnabled())
     ASSERT_EQ(1U, GetBubblesQueueSize(manager_a1));
   else
     ASSERT_EQ(1U, infobar_service_for_tab(0)->infobar_count());
 
   // Accept the second request and check that it's gone.
   if (BubbleEnabled()) {
     AcceptBubble(manager_a1);
@@ skipping 121 matching lines @@
   RequestGeolocationPermission(
       web_contents(), RequestID(0), requesting_frame_0, false);
   RequestGeolocationPermission(
       web_contents(), RequestID(1), requesting_frame_1, false);
 
   // Ensure only one infobar is created.
   ASSERT_EQ(1U, GetNumberOfPrompts());
 
   // Accept the first frame.
   AcceptPrompt();
-  if (!BubbleEnabled())
+  if (!BubbleEnabled()) {
     infobar_service()->RemoveInfoBar(infobar_service()->infobar_at(0));
+
+    // Make the next request appear after having checked that it was posted
+    // to the event loop.
+    ASSERT_TRUE(IsInfoBarShowPending(infobar_manager()));
+    ShowNextQueuedInfoBar(infobar_manager());
+  }
   CheckTabContentsState(requesting_frame_0, CONTENT_SETTING_ALLOW);
   CheckPermissionMessageSent(0, true);
 
   // Verify that accepting the first didn't accept because it's embedded
   // in the other.
   EXPECT_EQ(map->GetLastUsage(requesting_frame_0.GetOrigin(),
                               requesting_frame_0.GetOrigin(),
                               CONTENT_SETTINGS_TYPE_GEOLOCATION).ToDoubleT(),
             10);
   EXPECT_EQ(map->GetLastUsage(requesting_frame_1.GetOrigin(),
@@ skipping 30 matching lines @@
   // it is the embedder.
   EXPECT_EQ(map->GetLastUsage(requesting_frame_0.GetOrigin(),
                               requesting_frame_0.GetOrigin(),
                               CONTENT_SETTINGS_TYPE_GEOLOCATION).ToDoubleT(),
             13);
   EXPECT_EQ(map->GetLastUsage(requesting_frame_1.GetOrigin(),
                               requesting_frame_0.GetOrigin(),
                               CONTENT_SETTINGS_TYPE_GEOLOCATION).ToDoubleT(),
             11);
 }