Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 133783003: Removing the autofill enum which does not have reference in blink side (Closed)

Created:
6 years, 10 months ago by gnana
Modified:
6 years, 10 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Removing the autofill enum which does not have reference in blink side Removing the autofill enum and moving it to browser side in components/autofill/core/common/autofill_enums.h. This patch only removes the enum from the webautofillclient. Adding of enum in browser side is done in another patch. BUG=302489 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M public/web/WebAutofillClient.h View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
gnana
Please have a look
6 years, 10 months ago (2014-02-11 18:47:37 UTC) #1
blundell
LGTM You won't land this until the Chromium-side patch has landed, right?
6 years, 10 months ago (2014-02-11 20:31:52 UTC) #2
gnana
On 2014/02/11 20:31:52, blundell wrote: > LGTM > > You won't land this until the ...
6 years, 10 months ago (2014-02-12 06:07:59 UTC) #3
gnana
The CQ bit was checked by gnanasekar.s@samsung.com
6 years, 10 months ago (2014-02-22 07:46:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/133783003/1
6 years, 10 months ago (2014-02-22 07:46:34 UTC) #5
gnana
The CQ bit was unchecked by gnanasekar.s@samsung.com
6 years, 10 months ago (2014-02-22 07:59:48 UTC) #6
gnana
Need trivial LGTM for presubmit error
6 years, 10 months ago (2014-02-24 19:02:34 UTC) #7
gnana
On 2014/02/24 19:02:34, gnana wrote: > Need trivial LGTM for presubmit error Chromium-side patch is ...
6 years, 10 months ago (2014-02-24 19:04:16 UTC) #8
abarth-chromium
lgtm
6 years, 10 months ago (2014-02-24 20:19:21 UTC) #9
gnana
The CQ bit was checked by gnanasekar.s@samsung.com
6 years, 10 months ago (2014-02-25 06:45:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/133783003/1
6 years, 10 months ago (2014-02-25 06:49:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/133783003/1
6 years, 10 months ago (2014-02-25 07:45:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/133783003/1
6 years, 10 months ago (2014-02-25 13:25:50 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 14:37:18 UTC) #14
Message was sent while issue was closed.
Change committed as 167774

Powered by Google App Engine
This is Rietveld 408576698