Removing function filtering from the v8 sampling

Removing function filtering from the v8 sampling

Filtering out functions does not allow sample processor
to figure out if a sample hit a non-frame region of a function.

The filtering should be done in the frontend.

BUG=chromium:529931
LOG=N

Committed: https://crrev.com/32dffda6250f1d5a52908277eec8876eb5ebe43c
Cr-Commit-Position: refs/heads/master@{#30723}

[alph, 2015-09-11 01:44:40]

alph@chromium.org changed reviewers:
+ jkummerow@chromium.org, yurys@chromium.org

[Jakob Kummerow, 2015-09-11 09:27:07]

LGTM with comments:

In the BUG= line, please spell out "chromium:" explicitly in order to get
bugdroid to comment on the bug when the CL lands.

Does the tick processor script (tools/tickprocessor.js and friends) need
updating to keep working with this patch?

[yurys, 2015-09-11 16:11:48]

On 2015/09/11 09:27:07, Jakob wrote:
> Does the tick processor script (tools/tickprocessor.js and friends) need
> updating to keep working with this patch?

Tick processor already work in non-browser mode where the filter is no-op.

Alph, can we remove FLAG_prof_browser_mode flag altogether?

[alph, 2015-09-11 21:49:57]

On 2015/09/11 16:11:48, yurys wrote:
> On 2015/09/11 09:27:07, Jakob wrote:
> > Does the tick processor script (tools/tickprocessor.js and friends) need
> > updating to keep working with this patch?
> 
> Tick processor already work in non-browser mode where the filter is no-op.
> 
> Alph, can we remove FLAG_prof_browser_mode flag altogether?

We probably can, but it seems to be a matter for a separate patch.

[yurys, 2015-09-11 22:43:00]

lgtm provided that Chrome is ready to filter the new internal functions in
collected profiles.

[yurys, 2015-09-11 22:43:01]

lgtm provided that Chrome is ready to filter the new internal functions in
collected profiles.

[alph, 2015-09-15 00:59:25]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2015-09-15 00:59:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1337743002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1337743002/1

[commit-bot: I haz the power, 2015-09-15 01:21:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-15 01:22:09]

Patchset 1 (id:??) landed as
https://crrev.com/32dffda6250f1d5a52908277eec8876eb5ebe43c
Cr-Commit-Position: refs/heads/master@{#30723}