Fix of Hydrogen environment building for function "apply" calls

Fix of Hydrogen environment building for function "apply" calls.

BUG=v8:3084
R=jkummerow@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18548

[Jarin, 2014-01-10 12:48:55]

For fun.apply(receiver, arguments) call hydrogen-ization, moved the 'Pop' of the
function object after we evaluate the receiver (to be consistent with full code
gen). Added tests that trigger the issue.

[Jakob Kummerow, 2014-01-10 13:47:03]

LGTM with nits.

https://codereview.chromium.org/133773002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/133773002/diff/1/src/hydrogen.cc#newcode7572
src/hydrogen.cc:7572: Drop(1);  // Pop the function
nit: trailing full stop please.

https://codereview.chromium.org/133773002/diff/1/test/mjsunit/arguments-apply...
File test/mjsunit/arguments-apply-deopt.js (right):

https://codereview.chromium.org/133773002/diff/1/test/mjsunit/arguments-apply...
test/mjsunit/arguments-apply-deopt.js:32: return function XXXXX() {
nit: indentation is inconsistent here and again several times below.

https://codereview.chromium.org/133773002/diff/1/test/mjsunit/arguments-apply...
test/mjsunit/arguments-apply-deopt.js:49: for (var i = 0; i < 200; i++) {
use a smaller loop count here (say, 3), and %OptimizeFunctionOnNextCall as
necessary.

https://codereview.chromium.org/133773002/diff/1/test/mjsunit/arguments-apply...
test/mjsunit/arguments-apply-deopt.js:56: (function
ApplyArgumetsDeoptInReceiverExplicit() {
nit: s/Argumets/Arguments/

[Jarin, 2014-01-10 14:14:44]

All fixed now. Thanks!

https://codereview.chromium.org/133773002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/133773002/diff/1/src/hydrogen.cc#newcode7572
src/hydrogen.cc:7572: Drop(1);  // Pop the function
On 2014/01/10 13:47:03, Jakob wrote:
> nit: trailing full stop please.

Done.

https://codereview.chromium.org/133773002/diff/1/test/mjsunit/arguments-apply...
File test/mjsunit/arguments-apply-deopt.js (right):

https://codereview.chromium.org/133773002/diff/1/test/mjsunit/arguments-apply...
test/mjsunit/arguments-apply-deopt.js:32: return function XXXXX() {
On 2014/01/10 13:47:03, Jakob wrote:
> nit: indentation is inconsistent here and again several times below.

Done.

https://codereview.chromium.org/133773002/diff/1/test/mjsunit/arguments-apply...
test/mjsunit/arguments-apply-deopt.js:49: for (var i = 0; i < 200; i++) {
On 2014/01/10 13:47:03, Jakob wrote:
> use a smaller loop count here (say, 3), and %OptimizeFunctionOnNextCall as
> necessary.

Done.

https://codereview.chromium.org/133773002/diff/1/test/mjsunit/arguments-apply...
test/mjsunit/arguments-apply-deopt.js:56: (function
ApplyArgumetsDeoptInReceiverExplicit() {
On 2014/01/10 13:47:03, Jakob wrote:
> nit: s/Argumets/Arguments/

Done.

[Jarin, 2014-01-11 13:59:14]

Committed patchset #3 manually as r18548 (presubmit successful).