chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java - Issue 1337703002: [Contextual Search] Add support for crushed sprites and animate the search provider icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Issue 1337703002: [Contextual Search] Add support for crushed sprites and animate the search provider icon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes from newt@ review Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java » ('j') | chrome/browser/android/compositor/layer/crushed_sprite_layer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

index d6144848ec55fe7689e731dc24640f5b93b3b21a..9a1d12e151f282af2c3836d9b041e6f1a7a50359 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

@@ -495,6 +495,11 @@ public class ContextualSearchManager extends ContextualSearchObservable

mWereSearchResultsSeen = false;

+ mSearchPanelDelegate.setShouldAnimateSearchProviderIconSprite(

+ !mSearchPanelDelegate.isShowing()

pedro (no code reviews) 2015/09/29 01:14:40 Nit: Encapsulate the entire logic in the Contextua

Theresa 2015/10/01 01:57:31 Done.

+ && ContextualSearchPolicy.getInstance(mActivity).shouldAnimateSearchProviderIcon(

+ mSelectionController.getSelectionType()));

// TODO(donnd): although we are showing the bar here, we have not yet set the text!

// Refactor to show the bar and set the text at the same time!

// TODO(donnd): If there was a previously ongoing contextual search, we should ensure