chrome/android/java/res/values/dimens.xml - Issue 1337703002: [Contextual Search] Add support for crushed sprites and animate the search provider icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/values/dimens.xml

Issue 1337703002: [Contextual Search] Add support for crushed sprites and animate the search provider icon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Very small changes from last pedrosimonneti@ review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/android/jni_array.cc ('K') | « chrome/android/java/res/raw/google_icon_sprite.json ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchIconSpriteControl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/values/dimens.xml

diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml

index 521a415e80cb2d86a36fd2b5657e881ec136612f..b6f2b88b9e035cf5042558253b5bde568402727f 100644

--- a/chrome/android/java/res/values/dimens.xml

+++ b/chrome/android/java/res/values/dimens.xml

@@ -77,6 +77,9 @@

+ <!-- TODO(twellington): Consider moving this to the JSON sprite metadata and

newt (away) 2015/10/29 21:44:37 I'm not sure how aspirational or realistic this is

+ scaling the sprite in contextual_search_layer.cc -->

+ <dimen name="contextual_search_sprite_size">36dp</dimen>