[Contextual Search] Add support for crushed sprites and animate the search provider icon

build/android/lint/suppressions.xml

Index: build/android/lint/suppressions.xml
diff --git a/build/android/lint/suppressions.xml b/build/android/lint/suppressions.xml
index 97d5373afcfa6ed2081c209fb6ba8f8e019f310d..85347c63c4a87610a51cd7da41050f5e58212c27 100644
--- a/build/android/lint/suppressions.xml
+++ b/build/android/lint/suppressions.xml
@@ -53,6 +53,9 @@ Still reading?
     <ignore path="ui/android/java/res/drawable-xxxhdpi"/>
     <ignore regexp=".*: data_reduction_illustration.png, reader_mode_bar_background.9.png, tabs_moved_htc.png, tabs_moved_nexus.png, tabs_moved_samsung.png$"/>
   </issue>
+  <issue id="IconDipSize">
+    <ignore regexp=".*google_icon_sprite.png.*"/>

[newt (away), 2015/10/01 17:19:46]

Just confirming: this regex won't cause other IconDipSize warnings to be
ignored? And same with the InconsistentArrays regex below.

[Theresa, 2015/10/01 17:57:34]

Yes, it's a different line for each warning for both of these warnings.

For IconDipSize, I tested by changing account_manager_on_picture.png and saw
this warning with the lint suppression in place:
chrome/android/java/res/drawable-mdpi/account_management_no_picture.png The
image `account_management_no_picture.png` varies significantly in its
density-independent (dip) size across the various density versions:
drawable-hdpi/account_management_no_picture.png: 40x40 dp (60x60 px),
drawable-xhdpi/account_management_no_picture.png: 40x40 dp (80x80 px),
drawable-xxhdpi/account_management_no_picture.png: 40x40 dp (120x120 px),
drawable-xxxhdpi/account_management_no_picture.png: 40x40 dp (160x160 px),
drawable-mdpi/account_management_no_picture.png: 39x1000 dp (39x1000 px):
IconDipSize [warning]


For InconsistentArrays, if a second, differently named file has an array with
the same name as one of the arrays in
contextual_search_crushed_sprite_frames.xml and that array has a different # of
items, the error will still be suppressed. If two differently named files have
inconsistent arrays then the error will still be surfaced. The
InconsistentArrays warnings look like this:

chrome/android/java/res/values-hdpi/contextual_search_crushed_sprite_frames.xml:291
Array `contextual_search_sprite_frame_17` has an inconsistent number of items (0
in `values-ldpi/contextual_search_crushed_sprite_frames.xml`, 12 in
`values-hdpi/contextual_search_crushed_sprite_frames.xml`): InconsistentArrays
[warning]
  <integer-array name="contextual_search_sprite_frame_17">
  ^

I could make the regexp more specific, but I personally don't think it's
necessary.

[newt (away), 2015/10/01 18:18:04]

Sounds good to me. Thanks for confirming.

+  </issue>
   <issue id="IconLocation">
     <!-- It is OK for content_shell_apk to have missing assets. -->
     <ignore path="content/shell/android/java/res/"/>
@@ -61,6 +64,9 @@ Still reading?
     <!-- TODO(lambroslambrou) remove this once crbug.com/502030 is fixed. -->
     <ignore path="remoting/android/java/res"/>
   </issue>
+  <issue id="InconsistentArrays">
+    <ignore regexp=".*contextual_search_crushed_sprite_frames.xml.*"/>
+  </issue>
   <issue id="InconsistentLayout" severity="ignore"/>
   <issue id="InflateParams" severity="ignore"/>
   <issue id="MissingApplicationIcon" severity="ignore"/>