[Contextual Search] Add support for crushed sprites and animate the search provider icon

chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java
index c1ef52d91809d5eb5b8ea7c57dcc7348a6b33014..07eb5e209b5f952aa1d9e81071af154cbff601bf 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java
@@ -29,7 +29,8 @@ public abstract class ContextualSearchPanelAnimation extends ContextualSearchPan
     protected enum Property {
         PANEL_HEIGHT,
         PROMO_VISIBILITY,
-        BOTTOM_BAR_TEXT_VISIBILITY
+        BOTTOM_BAR_TEXT_VISIBILITY,
+        SEARCH_PROVIDER_ICON_SPRITE_FRAME

[pedro (no code reviews), 2015/09/11 22:49:42]

SPRITE and FRAME and technical details we should care about. I'd name this
SEARCH_PROVIDER_ICON_ANIMATION, which better describes its function (without
mentioning implementation details).

[Theresa, 2015/09/14 19:48:24]

Done.

     }
 
     /**
@@ -79,6 +80,11 @@ public abstract class ContextualSearchPanelAnimation extends ContextualSearchPan
     private final LayoutUpdateHost mUpdateHost;
 
     /**
+     * Whether the panel's open animation is running.
+     */
+    private boolean mIsAnimatingPanelOpen;
+
+    /**
      * Whether the panel's close animation is running.
      */
     private boolean mIsAnimatingPanelClosing;
@@ -124,6 +130,7 @@ public abstract class ContextualSearchPanelAnimation extends ContextualSearchPan
      * @param reason The reason for the change of panel state.
      */
     protected void peekPanel(StateChangeReason reason) {
+        mIsAnimatingPanelOpen = true;
         // Indicate to the Compositor that for now on the Panel should be
         // rendered, until it's closed.
         startShowing();
@@ -215,6 +222,18 @@ public abstract class ContextualSearchPanelAnimation extends ContextualSearchPan
     }
 
     /**
+     * Animates the search provider icon. This should only be called once the panel open
+     * animation has finished.
+     */
+    private void animateSearchProviderIcon() {
+        setIsSearchProviderIconVisible(true);
+        // TODO(twellington): tweak the duration once we have the final sprite sheets.
+        animateProperty(Property.SEARCH_PROVIDER_ICON_SPRITE_FRAME,
+                SEARCH_PROVIDER_ICON_FIRST_SPRITE_FRAME,

[pedro (no code reviews), 2015/09/11 22:49:42]

Similarly to the comment about the property name, I think we shouldn't care
about frames in here, which is an implementation detail. Instead, we should
provide a completion percentage (0..1), and then based on the completion,
duration and total number of frames we should be able to determine which frame
to render.

[Theresa, 2015/09/14 19:48:24]

Done.

+                SEARCH_PROVIDER_ICON_LAST_SPRITE_FRAME, 500);

[pedro (no code reviews), 2015/09/11 22:49:42]

Let's confirm the exact duration for the animation but I would think 500 it's
too much. In either case, we should have a constant for it (if not reusing the
existing duration constants).

[Theresa, 2015/09/14 19:48:24]

Acknowledged. I'll bring it up at the meeting today.

+    }
+
+    /**
      * Animates the Panel to its nearest state.
      */
     protected void animateToNearestState() {
@@ -367,6 +386,8 @@ public abstract class ContextualSearchPanelAnimation extends ContextualSearchPan
             setPromoVisibilityForOptInAnimation(value);
         } else if (prop == Property.BOTTOM_BAR_TEXT_VISIBILITY) {
             updateBottomBarTextVisibility(value);
+        } else if (prop == Property.SEARCH_PROVIDER_ICON_SPRITE_FRAME) {
+            setSearchProviderIconSpriteFrame((int) value);

[pedro (no code reviews), 2015/09/11 22:49:42]

For the reasons explained above, I think we should call this:
setSearchProviderIconAnimationCompletion(float percentage)

[Theresa, 2015/09/14 19:48:24]

Done.

         }
     }
 
@@ -414,6 +435,13 @@ public abstract class ContextualSearchPanelAnimation extends ContextualSearchPan
             mIsAnimatingPanelClosing = false;
         }
 
+        if (mIsAnimatingPanelOpen) {
+            mIsAnimatingPanelOpen = false;
+            if (shouldAnimateSearchProviderIcon()) {
+                animateSearchProviderIcon();
+            }
+        }
+
         // If animating to a particular PanelState, and after completing
         // resizing the Panel to its desired state, then the Panel's state
         // should be updated. This method also is called when an animation