[Contextual Search] Add support for crushed sprites and animate the search provider icon

chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.contextualsearch;
 
 import android.content.Context;
 
 import org.chromium.base.VisibleForTesting;
 import org.chromium.chrome.browser.ChromeVersionInfo;
 import org.chromium.chrome.browser.contextualsearch.ContextualSearchSelectionController.SelectionType;
 import org.chromium.chrome.browser.preferences.ChromePreferenceManager;
 import org.chromium.chrome.browser.preferences.NetworkPredictionOptions;
 import org.chromium.chrome.browser.preferences.PrefServiceBridge;
 import org.chromium.content.browser.ContentViewCore;
 
 import java.net.URL;
 import java.util.regex.Pattern;
 
 import javax.annotation.Nullable;
 
 
 /**
  * Handles policy decisions for the {@code ContextualSearchManager}.
  */
 class ContextualSearchPolicy {
     private static final Pattern CONTAINS_WHITESPACE_PATTERN = Pattern.compile("\\s");
     private static final int REMAINING_NOT_APPLICABLE = -1;
+    private static final int ONE_DAY_IN_MILLIS = 24 * 60 * 60 * 1000;
 
     private static ContextualSearchPolicy sInstance;
 
     private final ChromePreferenceManager mPreferenceManager;
 
     // Members used only for testing purposes.
     private boolean mDidOverrideDecidedStateForTesting;
     private boolean mDecidedStateForTesting;
     private boolean mDidResetCounters;
 
@@ skipping 258 matching lines @@
      * TODO(donnd): Update this API to definitively determine if it's OK to send the URL,
      * by merging the checks in the native contextual_search_delegate here.
      * @return {@code true} if the URL may be sent for policy reasons.
      *         Note that a return value of {@code true} may still require additional checks
      *         to see if all privacy-related conditions are met to send the base page URL.
      */
     boolean maySendBasePageUrl() {
         return !isUserUndecided();
     }
 
+    /**
+     * The search provider icon is animated every time on long press if the user has never opened
+     * the panel before and once a day on tap.
+     *
+     * @param selectionType The type of selection made by the user.
+     * @param isShowing Whether the panel is showing.
+     * @return Whether the search provider icon should be animated.
+     */
+    boolean shouldAnimateSearchProviderIcon(SelectionType selectionType, boolean isShowing) {
+        if (isShowing) {
+            return false;
+        }
+
+        if (selectionType == SelectionType.TAP) {
+            long currentTimeMillis = System.currentTimeMillis();
+            long lastAnimatedTimeMillis =
+                    mPreferenceManager.getContextualSearchLastAnimationTime();
+            if (Math.abs(currentTimeMillis - lastAnimatedTimeMillis) > ONE_DAY_IN_MILLIS) {
+                mPreferenceManager.setContextualSearchLastAnimationTime(currentTimeMillis);
+                return true;
+            } else {
+                return false;
+            }
+        } else if (selectionType == SelectionType.LONG_PRESS) {
+            return DisableablePromoTapCounter.getInstance(mPreferenceManager).isEnabled();

[pedro (no code reviews), 2015/10/27 20:32:00]

As we've discussed offline, this counter is for tap only, so we shouldn't be
using that.

I think we could use the getPromoOpenCount(), but that will only work if the
user is undecided (we only update the count if the promo is showing, which
happens when the user is undecided).

If the logic is that we should show it for long press only if the user has never
opened the panel before that would be OK since if the user has never opened the
panel, then the user must be undecided (can only decide after opening the
panel).

In either case, please write down some comment explaining this logic and why we
are reusing the PromoOpenCount, which is not immediately obvious to an
uninformed reader.

[Theresa, 2015/10/28 02:01:53]

Done.

+        }
+
+        return false;
+    }
+
     // --------------------------------------------------------------------------------------------
     // Testing support.
     // --------------------------------------------------------------------------------------------
 
     /**
      * Resets all policy counters.
      */
     @VisibleForTesting
     void resetCounters() {
         updateCountersForOpen();
@@ skipping 102 matching lines @@
 
     /**
      * @return The limit of the number of taps to resolve using search term resolution.
      */
     private int getTapResolveLimit() {
         return isUserUndecided()
                 ? ContextualSearchFieldTrial.getTapResolveLimitForUndecided()
                 : ContextualSearchFieldTrial.getTapResolveLimitForDecided();
     }
 }