[Contextual Search] Add support for crushed sprites and animate the search provider icon

chrome/browser/android/compositor/layer/contextual_search_layer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/compositor/layer/contextual_search_layer.h"
 
 #include "cc/layers/layer.h"
 #include "cc/layers/nine_patch_layer.h"
 #include "cc/layers/solid_color_layer.h"
 #include "cc/layers/ui_resource_layer.h"
@@ skipping 42 matching lines @@
     float search_panel_height,
     float search_bar_margin_side,
     float search_bar_height,
     float search_context_opacity,
     float search_term_opacity,
     bool search_bar_border_visible,
     float search_bar_border_y,
     float search_bar_border_height,
     bool search_bar_shadow_visible,
     float search_bar_shadow_opacity,
+    float search_provider_icon_sprite_size,
+    int search_provider_icon_sprite_frame,
     float arrow_icon_opacity,
     float arrow_icon_rotation,
     bool close_icon_visible,
     float close_icon_opacity,
     bool progress_bar_visible,
     float progress_bar_y,
     float progress_bar_height,
     float progress_bar_opacity,
     int progress_bar_completion) {
   // Grabs the dynamic Search Bar Text resource.
   ui::ResourceManager::Resource* search_context_resource =
       resource_manager_->GetResource(ui::ANDROID_RESOURCE_TYPE_DYNAMIC,
                                      search_context_resource_id);
   ui::ResourceManager::Resource* search_term_resource =
       resource_manager_->GetResource(ui::ANDROID_RESOURCE_TYPE_DYNAMIC,
                                      search_term_resource_id);
 
   // Grabs required static resources.
   ui::ResourceManager::Resource* panel_shadow_resource =
       resource_manager_->GetResource(ui::ANDROID_RESOURCE_TYPE_STATIC,
                                      panel_shadow_resource_id);
-  ui::ResourceManager::Resource* search_provider_icon_resource =
+  ui::ResourceManager::Resource* search_provider_icon_sprite_resource =
       resource_manager_->GetResource(ui::ANDROID_RESOURCE_TYPE_STATIC,
                                      search_provider_icon_resource_id);
 
   DCHECK(panel_shadow_resource);
-  DCHECK(search_provider_icon_resource);
+  DCHECK(search_provider_icon_sprite_resource);
 
   // Round values to avoid pixel gap between layers.
   search_bar_height = floor(search_bar_height);
 
   bool is_rtl = l10n_util::IsLayoutRtl();
 
   // ---------------------------------------------------------------------------
   // Panel Shadow
   // ---------------------------------------------------------------------------
   gfx::Size shadow_res_size = panel_shadow_resource->size;
@@ skipping 41 matching lines @@
         search_term_resource->size.height() / 2;
     search_term_->SetUIResourceId(search_term_resource->ui_resource->id());
     search_term_->SetBounds(search_term_resource->size);
     search_term_->SetPosition(gfx::PointF(0.f, search_bar_padding_top));
     search_term_->SetOpacity(search_term_opacity);
   }
 
   // ---------------------------------------------------------------------------
   // Search Provider Icon
   // ---------------------------------------------------------------------------
+  search_provider_icon_sprites_per_row_ =

[Changwan Ryu, 2015/09/17 06:10:08]

Actually, you don't need to keep these as member variables, and they are only
used in SetSearchProviderIconSpriteFrame(). How about passing
search_provider_icon_sprite_resource->size and search_provider_icon_sprite_size
to SetSearchProviderIconSpriteFrame() and calculate _per_row and _rows there?

[Theresa, 2015/09/25 00:58:13]

Done.

+      search_provider_icon_sprite_resource->size.width() /
+      search_provider_icon_sprite_size;
+  search_provider_icon_sprite_rows_ =
+      search_provider_icon_sprite_resource->size.height() /
+      search_provider_icon_sprite_size;
+
   // Positions the Search Provider Icon at the start of the Search Bar.
-  float search_provider_icon_left;
+  float icon_x;
   if (is_rtl) {
-    search_provider_icon_left = search_panel_width -
-        search_provider_icon_resource->size.width() - search_bar_margin_side;
+    icon_x = search_panel_width - search_provider_icon_sprite_size -
+        search_bar_margin_side;
   } else {
-    search_provider_icon_left = search_bar_margin_side;
+    icon_x = search_bar_margin_side;
   }
 
   // Centers the Search Provider Icon vertically in the Search Bar.
-  float search_provider_icon_top =
-      search_bar_height / 2 -
-      search_provider_icon_resource->size.height() / 2;
+  float icon_y = search_bar_height / 2 - search_provider_icon_sprite_size / 2;
+  search_provider_icon_sprite_->SetUIResourceId(
+      search_provider_icon_sprite_resource->ui_resource->id());
+  search_provider_icon_sprite_->SetBounds(
+      gfx::Size(search_provider_icon_sprite_size,
+                search_provider_icon_sprite_size));
+  search_provider_icon_sprite_->SetPosition(gfx::PointF(icon_x, icon_y));
 
-  search_provider_icon_->SetUIResourceId(
-      search_provider_icon_resource->ui_resource->id());
-  search_provider_icon_->SetBounds(search_provider_icon_resource->size);
-  search_provider_icon_->SetPosition(
-      gfx::PointF(search_provider_icon_left, search_provider_icon_top));
+  // Sets the portion of search_provider_icon_ that gets drawn.
+  SetSearchProviderIconSpriteFrame(search_provider_icon_sprite_frame);
 
   // ---------------------------------------------------------------------------
   // Arrow Icon
   // ---------------------------------------------------------------------------
   // Grabs the Search Arrow Icon resource.
   ui::ResourceManager::Resource* arrow_icon_resource =
       resource_manager_->GetResource(ui::ANDROID_RESOURCE_TYPE_STATIC,
                                      arrow_up_resource_id);
   if (arrow_icon_->parent() != layer_) {
     layer_->AddChild(arrow_icon_);
@@ skipping 226 matching lines @@
       panel_shadow_(
           cc::NinePatchLayer::Create(content::Compositor::LayerSettings())),
       search_bar_background_(
           cc::SolidColorLayer::Create(content::Compositor::LayerSettings())),
       search_context_(
           cc::UIResourceLayer::Create(content::Compositor::LayerSettings())),
       search_term_(
           cc::UIResourceLayer::Create(content::Compositor::LayerSettings())),
       search_bar_shadow_(
           cc::UIResourceLayer::Create(content::Compositor::LayerSettings())),
-      search_provider_icon_(
+      search_provider_icon_sprite_(
           cc::UIResourceLayer::Create(content::Compositor::LayerSettings())),
       arrow_icon_(
           cc::UIResourceLayer::Create(content::Compositor::LayerSettings())),
       close_icon_(
           cc::UIResourceLayer::Create(content::Compositor::LayerSettings())),
       content_view_container_(
           cc::Layer::Create(content::Compositor::LayerSettings())),
       search_bar_border_(
           cc::SolidColorLayer::Create(content::Compositor::LayerSettings())),
       progress_bar_(
           cc::NinePatchLayer::Create(content::Compositor::LayerSettings())),
       progress_bar_background_(
           cc::NinePatchLayer::Create(content::Compositor::LayerSettings())),
       search_promo_(
           cc::UIResourceLayer::Create(content::Compositor::LayerSettings())),
       search_promo_container_(
-          cc::SolidColorLayer::Create(content::Compositor::LayerSettings())) {
+          cc::SolidColorLayer::Create(content::Compositor::LayerSettings())),
+      search_provider_icon_sprites_per_row_(0),
+      search_provider_icon_sprite_rows_(0) {
   layer_->SetMasksToBounds(false);
   layer_->SetIsDrawable(true);
 
   // Panel Shadow
   panel_shadow_->SetIsDrawable(true);
   panel_shadow_->SetFillCenter(false);
   layer_->AddChild(panel_shadow_);
 
   // Search Bar Background
   search_bar_background_->SetIsDrawable(true);
   search_bar_background_->SetBackgroundColor(kSearchBarBackgroundColor);
   layer_->AddChild(search_bar_background_);
 
   // Search Bar Text
   search_context_->SetIsDrawable(true);
   layer_->AddChild(search_context_);
   search_term_->SetIsDrawable(true);
   layer_->AddChild(search_term_);
 
   // Search Provider Icon
-  search_provider_icon_->SetIsDrawable(true);
-  layer_->AddChild(search_provider_icon_);
+  search_provider_icon_sprite_->SetIsDrawable(true);
+  layer_->AddChild(search_provider_icon_sprite_);
 
   // Arrow Icon
   arrow_icon_->SetIsDrawable(true);
 
   // Close Icon
   close_icon_->SetIsDrawable(true);
 
   // Search Opt Out Promo
   search_promo_container_->SetIsDrawable(true);
   search_promo_container_->SetBackgroundColor(kSearchBackgroundColor);
@@ skipping 18 matching lines @@
   search_bar_shadow_->SetIsDrawable(true);
 }
 
 ContextualSearchLayer::~ContextualSearchLayer() {
 }
 
 scoped_refptr<cc::Layer> ContextualSearchLayer::layer() {
   return layer_;
 }
 
+void ContextualSearchLayer::SetSearchProviderIconSpriteFrame(int sprite_frame) {
+  float column = static_cast<float>(
+      sprite_frame % search_provider_icon_sprites_per_row_);
+  float row = static_cast<float>(
+      sprite_frame / search_provider_icon_sprites_per_row_);
+  CHECK(row <= search_provider_icon_sprite_rows_);
+
+  float top_left_x = column /
+      static_cast<float>(search_provider_icon_sprites_per_row_);
+  float top_left_y = row /
+      static_cast<float>(search_provider_icon_sprite_rows_);
+  float bottom_right_x = (column + 1.f) /
+      static_cast<float>(search_provider_icon_sprites_per_row_);
+  float bottom_right_y = (row + 1.f) /
+      static_cast<float>(search_provider_icon_sprite_rows_);
+  search_provider_icon_sprite_->SetUV(gfx::PointF(top_left_x, top_left_y),
+                               gfx::PointF(bottom_right_x, bottom_right_y));

[Changwan Ryu, 2015/09/17 06:10:08]

nit: indentation

[Theresa, 2015/09/25 00:58:14]

Acknowledged.

+}
+
 }  //  namespace android
 }  //  namespace chrome