Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: build/android/lint/suppressions.xml

Issue 1337703002: [Contextual Search] Add support for crushed sprites and animate the search provider icon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 <ignore path="components/web_contents_delegate_android/android/java/res/draw able-xxhdpi"/> 46 <ignore path="components/web_contents_delegate_android/android/java/res/draw able-xxhdpi"/>
47 <ignore path="components/web_contents_delegate_android/android/java/res/draw able-xxxhdpi"/> 47 <ignore path="components/web_contents_delegate_android/android/java/res/draw able-xxxhdpi"/>
48 <ignore path="content/public/android/java/res/drawable-xxhdpi"/> 48 <ignore path="content/public/android/java/res/drawable-xxhdpi"/>
49 <ignore path="content/public/android/java/res/drawable-xxxhdpi"/> 49 <ignore path="content/public/android/java/res/drawable-xxxhdpi"/>
50 <ignore path="chrome/android/java/res/drawable-xxhdpi"/> 50 <ignore path="chrome/android/java/res/drawable-xxhdpi"/>
51 <ignore path="chrome/android/java/res/drawable-xxxhdpi"/> 51 <ignore path="chrome/android/java/res/drawable-xxxhdpi"/>
52 <ignore path="ui/android/java/res/drawable-xxhdpi"/> 52 <ignore path="ui/android/java/res/drawable-xxhdpi"/>
53 <ignore path="ui/android/java/res/drawable-xxxhdpi"/> 53 <ignore path="ui/android/java/res/drawable-xxxhdpi"/>
54 <ignore regexp=".*: data_reduction_illustration.png, reader_mode_bar_backgro und.9.png, tabs_moved_htc.png, tabs_moved_nexus.png, tabs_moved_samsung.png$"/> 54 <ignore regexp=".*: data_reduction_illustration.png, reader_mode_bar_backgro und.9.png, tabs_moved_htc.png, tabs_moved_nexus.png, tabs_moved_samsung.png$"/>
55 </issue> 55 </issue>
56 <issue id="IconDipSize">
57 <ignore regexp=".*google_icon_sprite.png.*"/>
newt (away) 2015/10/01 17:19:46 Just confirming: this regex won't cause other Icon
Theresa 2015/10/01 17:57:34 Yes, it's a different line for each warning for bo
newt (away) 2015/10/01 18:18:04 Sounds good to me. Thanks for confirming.
58 </issue>
56 <issue id="IconLocation"> 59 <issue id="IconLocation">
57 <!-- It is OK for content_shell_apk to have missing assets. --> 60 <!-- It is OK for content_shell_apk to have missing assets. -->
58 <ignore path="content/shell/android/java/res/"/> 61 <ignore path="content/shell/android/java/res/"/>
59 <!-- Suppression for chrome/test/chromedriver/test/webview_shell/java/res/dr awable/icon.png --> 62 <!-- Suppression for chrome/test/chromedriver/test/webview_shell/java/res/dr awable/icon.png -->
60 <ignore path="res/drawable/icon.png"/> 63 <ignore path="res/drawable/icon.png"/>
61 <!-- TODO(lambroslambrou) remove this once crbug.com/502030 is fixed. --> 64 <!-- TODO(lambroslambrou) remove this once crbug.com/502030 is fixed. -->
62 <ignore path="remoting/android/java/res"/> 65 <ignore path="remoting/android/java/res"/>
63 </issue> 66 </issue>
67 <issue id="InconsistentArrays">
68 <ignore regexp=".*contextual_search_crushed_sprite_frames.xml.*"/>
69 </issue>
64 <issue id="InconsistentLayout" severity="ignore"/> 70 <issue id="InconsistentLayout" severity="ignore"/>
65 <issue id="InflateParams" severity="ignore"/> 71 <issue id="InflateParams" severity="ignore"/>
66 <issue id="MissingApplicationIcon" severity="ignore"/> 72 <issue id="MissingApplicationIcon" severity="ignore"/>
67 <issue id="MissingRegistered" severity="ignore"/> 73 <issue id="MissingRegistered" severity="ignore"/>
68 <issue id="MissingVersion"> 74 <issue id="MissingVersion">
69 <ignore path="AndroidManifest.xml"/> 75 <ignore path="AndroidManifest.xml"/>
70 </issue> 76 </issue>
71 <issue id="InlinedApi" severity="ignore"/> 77 <issue id="InlinedApi" severity="ignore"/>
72 <issue id="NewApi"> 78 <issue id="NewApi">
73 <ignore regexp="Attribute `paddingStart` referenced here can result in a cra sh on some specific devices older than API 17"/> 79 <ignore regexp="Attribute `paddingStart` referenced here can result in a cra sh on some specific devices older than API 17"/>
(...skipping 27 matching lines...) Expand all
101 <ignore path="content/shell/android/shell_apk/res/values/strings.xml" /> 107 <ignore path="content/shell/android/shell_apk/res/values/strings.xml" />
102 </issue> 108 </issue>
103 <issue id="SignatureOrSystemPermissions" severity="ignore"/> 109 <issue id="SignatureOrSystemPermissions" severity="ignore"/>
104 <issue id="UnusedAttribute" severity="ignore"/> 110 <issue id="UnusedAttribute" severity="ignore"/>
105 <issue id="ViewConstructor" severity="ignore"/> 111 <issue id="ViewConstructor" severity="ignore"/>
106 <issue id="WrongCall" severity="ignore"/> 112 <issue id="WrongCall" severity="ignore"/>
107 <issue id="UselessParent"> 113 <issue id="UselessParent">
108 <ignore path="chrome/android/java/res/layout/data_reduction_promo_screen.xml " /> 114 <ignore path="chrome/android/java/res/layout/data_reduction_promo_screen.xml " />
109 </issue> 115 </issue>
110 </lint> 116 </lint>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698