[Contextual Search] Add support for crushed sprites and animate the search provider icon

chrome/browser/android/compositor/layer/contextual_search_layer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/compositor/layer/contextual_search_layer.h"
 
 #include "cc/layers/layer.h"
 #include "cc/layers/nine_patch_layer.h"
 #include "cc/layers/solid_color_layer.h"
 #include "cc/layers/ui_resource_layer.h"
@@ skipping 42 matching lines @@
     float search_panel_height,
     float search_bar_margin_side,
     float search_bar_height,
     float search_context_opacity,
     float search_term_opacity,
     bool search_bar_border_visible,
     float search_bar_border_y,
     float search_bar_border_height,
     bool search_bar_shadow_visible,
     float search_bar_shadow_opacity,
+    bool search_provider_icon_visible,
+    int search_provider_icon_sprites_per_row,
+    int search_provider_icon_sprite_rows,
+    int search_provider_icon_sprite_frame,
     float arrow_icon_opacity,
     float arrow_icon_rotation,
     bool close_icon_visible,
     float close_icon_opacity,
     bool progress_bar_visible,
     float progress_bar_y,
     float progress_bar_height,
     float progress_bar_opacity,
     int progress_bar_completion) {
   // Grabs the dynamic Search Bar Text resource.
@@ skipping 68 matching lines @@
         search_term_resource->size.height() / 2;
     search_term_->SetUIResourceId(search_term_resource->ui_resource->id());
     search_term_->SetBounds(search_term_resource->size);
     search_term_->SetPosition(gfx::PointF(0.f, search_bar_padding_top));
     search_term_->SetOpacity(search_term_opacity);
   }
 
   // ---------------------------------------------------------------------------
   // Search Provider Icon
   // ---------------------------------------------------------------------------
-  // Positions the Search Provider Icon at the start of the Search Bar.
-  float search_provider_icon_left;
-  if (is_rtl) {
-    search_provider_icon_left = search_panel_width -
-        search_provider_icon_resource->size.width() - search_bar_margin_side;
+  if (search_provider_icon_visible) {
+    if (search_provider_icon_->parent() != layer_) {

[pedro (no code reviews), 2015/09/11 22:49:42]

Nit: please rename search_provider_icon_ to search_provider_icon_sprite_

[Theresa, 2015/09/14 19:48:25]

Done.

+      layer_->AddChild(search_provider_icon_);
+    }
+
+    search_provider_icon_sprites_per_row_ =
+        search_provider_icon_sprites_per_row;
+    search_provider_icon_sprite_rows_ = search_provider_icon_sprite_rows;
+    float search_provider_icon_sprite_width =

[Changwan Ryu, 2015/09/14 01:51:30]

Nit: How about just naming them icon_width and icon_height? They are scoped in
the if statement anyways.

[Theresa, 2015/09/14 19:48:25]

Acknowledged. This value is getting passed in now, so it needs a more
descriptive name.

+        search_provider_icon_resource->size.width() /
+        search_provider_icon_sprites_per_row_;
+    float search_provider_icon_sprite_height =
+        search_provider_icon_resource->size.height() /
+        search_provider_icon_sprite_rows_;
+
+    // Positions the Search Provider Icon at the start of the Search Bar.
+    float search_provider_icon_left;

[Changwan Ryu, 2015/09/14 01:51:30]

Nit: how about icon_x and icon_y for simplicity?

[Theresa, 2015/09/14 19:48:25]

Done.

+    if (is_rtl) {
+      search_provider_icon_left = search_panel_width -
+          search_provider_icon_sprite_width - search_bar_margin_side;
+    } else {
+      search_provider_icon_left = search_bar_margin_side;
+    }
+
+    // Centers the Search Provider Icon vertically in the Search Bar.
+    float search_provider_icon_top =
+        search_bar_height / 2 -
+        search_provider_icon_sprite_height / 2;
+    search_provider_icon_->SetUIResourceId(
+        search_provider_icon_resource->ui_resource->id());
+    gfx::Size* size = new gfx::Size(search_provider_icon_sprite_width,
+                                    search_provider_icon_sprite_height);

[Changwan Ryu, 2015/09/14 01:51:29]

gfx::Size size(search_provider_icon_sprite_width,
search_provider_icon_sprite_height);

Or could be inlined in SetBounds(), just as you did in the next line.
It's currently leaking.

[Theresa, 2015/09/14 19:48:25]

Done.

+    search_provider_icon_->SetBounds(*size);
+    search_provider_icon_->SetPosition(
+        gfx::PointF(search_provider_icon_left, search_provider_icon_top));
+
+    // Sets the portion of search_provider_icon_ that gets drawn.
+    SetSearchProviderIconUV(search_provider_icon_sprite_frame);
   } else {
-    search_provider_icon_left = search_bar_margin_side;
+    if (search_provider_icon_.get() && search_provider_icon_->parent()) {
+      search_provider_icon_->RemoveFromParent();
+    }
   }
 
-  // Centers the Search Provider Icon vertically in the Search Bar.
-  float search_provider_icon_top =
-      search_bar_height / 2 -
-      search_provider_icon_resource->size.height() / 2;
-
-  search_provider_icon_->SetUIResourceId(
-      search_provider_icon_resource->ui_resource->id());
-  search_provider_icon_->SetBounds(search_provider_icon_resource->size);
-  search_provider_icon_->SetPosition(
-      gfx::PointF(search_provider_icon_left, search_provider_icon_top));
-
   // ---------------------------------------------------------------------------
   // Arrow Icon
   // ---------------------------------------------------------------------------
   // Grabs the Search Arrow Icon resource.
   ui::ResourceManager::Resource* arrow_icon_resource =
       resource_manager_->GetResource(ui::ANDROID_RESOURCE_TYPE_STATIC,
                                      arrow_up_resource_id);
   if (arrow_icon_->parent() != layer_) {
     layer_->AddChild(arrow_icon_);
   }
@@ skipping 242 matching lines @@
           cc::Layer::Create(content::Compositor::LayerSettings())),
       search_bar_border_(
           cc::SolidColorLayer::Create(content::Compositor::LayerSettings())),
       progress_bar_(
           cc::NinePatchLayer::Create(content::Compositor::LayerSettings())),
       progress_bar_background_(
           cc::NinePatchLayer::Create(content::Compositor::LayerSettings())),
       search_promo_(
           cc::UIResourceLayer::Create(content::Compositor::LayerSettings())),
       search_promo_container_(
-          cc::SolidColorLayer::Create(content::Compositor::LayerSettings())) {
+          cc::SolidColorLayer::Create(content::Compositor::LayerSettings())),
+      search_provider_icon_sprites_per_row_(0),
+      search_provider_icon_sprite_rows_(0) {
   layer_->SetMasksToBounds(false);
   layer_->SetIsDrawable(true);
 
   // Panel Shadow
   panel_shadow_->SetIsDrawable(true);
   panel_shadow_->SetFillCenter(false);
   layer_->AddChild(panel_shadow_);
 
   // Search Bar Background
   search_bar_background_->SetIsDrawable(true);
@@ skipping 40 matching lines @@
   search_bar_shadow_->SetIsDrawable(true);
 }
 
 ContextualSearchLayer::~ContextualSearchLayer() {
 }
 
 scoped_refptr<cc::Layer> ContextualSearchLayer::layer() {
   return layer_;
 }
 
+void ContextualSearchLayer::SetSearchProviderIconUV(int sprite_frame) {

[pedro (no code reviews), 2015/09/11 22:49:42]

I think it would make more sense to call this
SetSearchProviderIconSpriteFrame(), which is more meaningful.

[Theresa, 2015/09/14 19:48:25]

Done.

+  float column = (float) (sprite_frame % search_provider_icon_sprites_per_row_);

[Changwan Ryu, 2015/09/14 01:51:30]

Please do not use C-style casting, and use static_cast<> when applicable.

[Theresa, 2015/09/14 19:48:25]

Done.

+  float row = (float) (sprite_frame / search_provider_icon_sprites_per_row_);
+  CHECK(row <= search_provider_icon_sprite_rows_);
+
+  float top_left_x = column / ((float) search_provider_icon_sprites_per_row_);
+  float top_left_y = row / ((float) search_provider_icon_sprite_rows_);
+  float bottom_right_x = (column + 1.f) /
+      ((float) search_provider_icon_sprites_per_row_);
+  float bottom_right_y = (row + 1.f) /
+      ((float) search_provider_icon_sprite_rows_);
+  search_provider_icon_->SetUV(gfx::PointF(top_left_x, top_left_y),
+                               gfx::PointF(bottom_right_x, bottom_right_y));
+}
+
 }  //  namespace android
 }  //  namespace chrome