Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: test/cctest/test-api.cc

Issue 133763005: Fix r18556; tests were missing handlescopes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/test-parsing.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index fe6ec1f2ff8ee7a103839891f21b787b683e77ee..839ddd9858f5cb43bae637531c55742a601a328b 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -14785,6 +14785,7 @@ TEST(PreCompile) {
// a workaround for now to make this test not fail.
v8::V8::Initialize();
v8::Isolate* isolate = CcTest::isolate();
+ HandleScope handle_scope(isolate);
const char* script = "function foo(a) { return a+1; }";
v8::ScriptData* sd = v8::ScriptData::PreCompile(v8::String::NewFromUtf8(
isolate, script, v8::String::kNormalString, i::StrLength(script)));
@@ -14798,6 +14799,7 @@ TEST(PreCompile) {
TEST(PreCompileWithError) {
v8::V8::Initialize();
v8::Isolate* isolate = CcTest::isolate();
+ HandleScope handle_scope(isolate);
const char* script = "function foo(a) { return 1 * * 2; }";
v8::ScriptData* sd = v8::ScriptData::PreCompile(v8::String::NewFromUtf8(
isolate, script, v8::String::kNormalString, i::StrLength(script)));
@@ -14809,6 +14811,7 @@ TEST(PreCompileWithError) {
TEST(Regress31661) {
v8::V8::Initialize();
v8::Isolate* isolate = CcTest::isolate();
+ HandleScope handle_scope(isolate);
const char* script = " The Definintive Guide";
v8::ScriptData* sd = v8::ScriptData::PreCompile(v8::String::NewFromUtf8(
isolate, script, v8::String::kNormalString, i::StrLength(script)));
@@ -14821,6 +14824,7 @@ TEST(Regress31661) {
TEST(PreCompileSerialization) {
v8::V8::Initialize();
v8::Isolate* isolate = CcTest::isolate();
+ HandleScope handle_scope(isolate);
const char* script = "function foo(a) { return a+1; }";
v8::ScriptData* sd = v8::ScriptData::PreCompile(v8::String::NewFromUtf8(
isolate, script, v8::String::kNormalString, i::StrLength(script)));
« no previous file with comments | « no previous file | test/cctest/test-parsing.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698