Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 13376002: base: Consolidate all test data directories under base/test/data. (Closed)

Created:
7 years, 8 months ago by tfarina
Modified:
7 years, 8 months ago
CC:
chromium-reviews, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

base: Consolidate all test data directories under base/test/data. This is the follow up patch I promised in r191077 - https://chromiumcodereview.appspot.com/12481028 TEST=base_unittests R=darin@chromium.org,bulach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192780

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-15 lines, -67 lines) Patch
M base/base.gyp View 1 1 chunk +0 lines, -3 lines 0 comments Download
D base/data/file_util_unittest/binary_file.bin View 0 chunks +-1 lines, --1 lines 0 comments Download
D base/data/file_util_unittest/binary_file_diff.bin View 0 chunks +-1 lines, --1 lines 0 comments Download
D base/data/file_util_unittest/binary_file_same.bin View 0 chunks +-1 lines, --1 lines 0 comments Download
D base/data/file_util_unittest/blank_line.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D base/data/file_util_unittest/blank_line_crlf.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D base/data/file_util_unittest/crlf.txt View 1 chunk +0 lines, -1 line 0 comments Download
D base/data/file_util_unittest/different.txt View 1 chunk +0 lines, -1 line 0 comments Download
D base/data/file_util_unittest/different_first.txt View 1 chunk +0 lines, -1 line 0 comments Download
D base/data/file_util_unittest/different_last.txt View 1 chunk +0 lines, -1 line 0 comments Download
D base/data/file_util_unittest/empty1.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D base/data/file_util_unittest/empty2.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D base/data/file_util_unittest/first1.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D base/data/file_util_unittest/first2.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D base/data/file_util_unittest/original.txt View 1 chunk +0 lines, -1 line 0 comments Download
D base/data/file_util_unittest/same.txt View 1 chunk +0 lines, -1 line 0 comments Download
D base/data/file_util_unittest/same_length.txt View 1 chunk +0 lines, -1 line 0 comments Download
D base/data/file_util_unittest/shortened.txt View 1 chunk +0 lines, -1 line 0 comments Download
D base/data/json/bom_feff.json View 1 chunk +0 lines, -10 lines 0 comments Download
M base/file_util_unittest.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M base/json/json_reader_unittest.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M base/prefs/json_pref_store_unittest.cc View 1 chunk +1 line, -6 lines 0 comments Download
D base/prefs/test/data/pref_service/invalid.json View 1 chunk +0 lines, -1 line 0 comments Download
D base/prefs/test/data/pref_service/read.json View 1 chunk +0 lines, -8 lines 0 comments Download
D base/prefs/test/data/pref_service/read.need_empty_value.json View 1 chunk +0 lines, -10 lines 0 comments Download
D base/prefs/test/data/pref_service/write.golden.json View 1 chunk +0 lines, -11 lines 0 comments Download
D base/prefs/test/data/pref_service/write.golden.need_empty_value.json View 1 chunk +0 lines, -6 lines 0 comments Download
A + base/test/data/file_util/blank_line.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/file_util/blank_line_crlf.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/file_util/crlf.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/file_util/different.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/file_util/different_first.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/file_util/different_last.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/file_util/empty1.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/file_util/empty2.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/file_util/first1.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/file_util/first2.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/file_util/original.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/file_util/same.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/file_util/same_length.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/file_util/shortened.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/prefs/invalid.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/prefs/read.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/prefs/read.need_empty_value.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/prefs/write.golden.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/data/prefs/write.golden.need_empty_value.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M build/android/pylib/gtest/test_runner.py View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tfarina
Hi Darin, Marcus, could you review this to me? Thanks,
7 years, 8 months ago (2013-03-30 02:23:25 UTC) #1
tfarina
I'll have to copy the binaries first, otherwise I won't be able to run the ...
7 years, 8 months ago (2013-03-30 02:39:00 UTC) #2
tfarina
Committed https://codereview.chromium.org/13386003/ and rebased this. Please, take another look. Thanks,
7 years, 8 months ago (2013-03-30 20:41:14 UTC) #3
tfarina
Looks like I'll have to copy bom_feff.json too. svn: File 'base\test\data\json\bom_feff.json' has binary mime type ...
7 years, 8 months ago (2013-03-30 21:02:06 UTC) #4
tfarina
Committed https://codereview.chromium.org/13165004/, trybots are happy now :)
7 years, 8 months ago (2013-03-30 22:27:03 UTC) #5
tfarina
Ping??
7 years, 8 months ago (2013-04-01 21:17:03 UTC) #6
bulach
lgtm (but I'm not an owner on all the files), thanks for cleaning this up!
7 years, 8 months ago (2013-04-02 11:27:13 UTC) #7
tfarina
Brett, in the absence of Darin, could you do the review here? Thank you!
7 years, 8 months ago (2013-04-02 22:04:37 UTC) #8
brettw
lgtm
7 years, 8 months ago (2013-04-03 05:18:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/13376002/9001
7 years, 8 months ago (2013-04-07 12:08:56 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-07 12:17:01 UTC) #11
tfarina
7 years, 8 months ago (2013-04-07 16:28:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 manually as r192780 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698