Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1337523002: DevTools: issue detach notification when frontend api connection is kicked out. (Closed)

Created:
5 years, 3 months ago by pfeldman
Modified:
5 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: issue detach notification when frontend api connection is kicked out. BUG=456547 Committed: https://crrev.com/5d01c4dc1777697309a47c606654f984c60614d8 Cr-Commit-Position: refs/heads/master@{#348277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pfeldman
5 years, 3 months ago (2015-09-10 19:01:50 UTC) #2
dgozman
lgtm
5 years, 3 months ago (2015-09-10 21:47:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337523002/1
5 years, 3 months ago (2015-09-10 22:00:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 23:17:42 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5d01c4dc1777697309a47c606654f984c60614d8 Cr-Commit-Position: refs/heads/master@{#348277}
5 years, 3 months ago (2015-09-10 23:18:17 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:16:06 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5d01c4dc1777697309a47c606654f984c60614d8
Cr-Commit-Position: refs/heads/master@{#348277}

Powered by Google App Engine
This is Rietveld 408576698