Add blink embedder APIs for DomKey conversion.

Add blink embedder APIs for DomKey conversion.

Implement the platform APIs for DomKey conversion.

BUG=227231
Committed: https://crrev.com/df58b20defbccafbd9fa35ba2842e56b687a07fc
Cr-Commit-Position: refs/heads/master@{#348290}

[dtapuska, 2015-09-10 15:47:12]

dtapuska@chromium.org changed reviewers:
+ piman@chromium.org

[dtapuska, 2015-09-10 15:48:26]

piman as reviewer; as he reviewed https://codereview.chromium.org/929053004/

which this change is ultimately a replacement for.

[piman, 2015-09-10 18:27:40]

lgtm

https://codereview.chromium.org/1337503002/diff/1/content/child/blink_platfor...
File content/child/blink_platform_impl.cc (right):

https://codereview.chromium.org/1337503002/diff/1/content/child/blink_platfor...
content/child/blink_platform_impl.cc:1379: static_cast<ui::DomKey>(dom_key)));
nit: do we need a range check to make sure this static_cast is valid?

[kpschoedel, 2015-09-10 18:41:29]

kpschoedel@chromium.org changed reviewers:
+ kpschoedel@chromium.org

[kpschoedel, 2015-09-10 18:41:30]

https://codereview.chromium.org/1337503002/diff/1/content/child/blink_platfor...
File content/child/blink_platform_impl.cc (right):

https://codereview.chromium.org/1337503002/diff/1/content/child/blink_platfor...
content/child/blink_platform_impl.cc:1379: static_cast<ui::DomKey>(dom_key)));
On 2015/09/10 18:27:40, piman (slow to review) wrote:
> nit: do we need a range check to make sure this static_cast is valid?

I can answer this: |ui::DomKey| is explicitly designed to be inter-convertable
with opaque |int| values for Blink's use. Non-opaque accessors for it have
DCHECKs as necessary, and |DomKeyToKeyString()| returns the empty string for
invalid integers (as defined for uninitialized values in the UI Events spec).

[dtapuska, 2015-09-10 22:57:57]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2015-09-10 22:58:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1337503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1337503002/1

[commit-bot: I haz the power, 2015-09-11 00:00:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-11 00:00:54]

Patchset 1 (id:??) landed as
https://crrev.com/df58b20defbccafbd9fa35ba2842e56b687a07fc
Cr-Commit-Position: refs/heads/master@{#348290}

[commit-bot: I haz the power, 2015-09-23 12:16:39]

Patchset 1 (id:??) landed as
https://crrev.com/df58b20defbccafbd9fa35ba2842e56b687a07fc
Cr-Commit-Position: refs/heads/master@{#348290}