Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: extensions/common/view_type.h

Issue 13375017: Move the ViewType enum to extensions\common. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/view_type.h
===================================================================
--- extensions/common/view_type.h (revision 191609)
+++ extensions/common/view_type.h (working copy)
@@ -2,13 +2,13 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_COMMON_VIEW_TYPE_H_
-#define CHROME_COMMON_VIEW_TYPE_H_
+#ifndef EXTENSIONS_COMMON_VIEW_TYPE_H_
+#define EXTENSIONS_COMMON_VIEW_TYPE_H_
-namespace chrome {
+namespace extensions {
// Icky RTTI used by a few systems to distinguish the host type of a given
-// RenderViewHost or WebContents.
+// WebContents.
//
// TODO(aa): Remove this and teach those systems to keep track of their own
// data.
@@ -20,6 +20,8 @@
VIEW_TYPE_EXTENSION_DIALOG,
VIEW_TYPE_EXTENSION_INFOBAR,
VIEW_TYPE_EXTENSION_POPUP,
+ // TODO(jam): remove this once http://crbug.com/137297 is fixed and HTML5
+ // notifications don't use WebContents.
VIEW_TYPE_NOTIFICATION,
VIEW_TYPE_PANEL,
VIEW_TYPE_TAB_CONTENTS,
@@ -37,6 +39,6 @@
extern const char kViewTypePopup[];
extern const char kViewTypeTabContents[];
-} // namespace chrome
+} // namespace extensions
-#endif // CHROME_COMMON_VIEW_TYPE_H_
+#endif // EXTENSIONS_COMMON_VIEW_TYPE_H_

Powered by Google App Engine
This is Rietveld 408576698