Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4568)

Unified Diff: chrome/common/view_type.h

Issue 13375017: Move the ViewType enum to extensions\common. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/view_type.h
===================================================================
--- chrome/common/view_type.h (revision 191609)
+++ chrome/common/view_type.h (working copy)
@@ -1,42 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_COMMON_VIEW_TYPE_H_
-#define CHROME_COMMON_VIEW_TYPE_H_
-
-namespace chrome {
-
-// Icky RTTI used by a few systems to distinguish the host type of a given
-// RenderViewHost or WebContents.
-//
-// TODO(aa): Remove this and teach those systems to keep track of their own
-// data.
-enum ViewType {
- VIEW_TYPE_INVALID,
- VIEW_TYPE_APP_SHELL,
- VIEW_TYPE_BACKGROUND_CONTENTS,
- VIEW_TYPE_EXTENSION_BACKGROUND_PAGE,
- VIEW_TYPE_EXTENSION_DIALOG,
- VIEW_TYPE_EXTENSION_INFOBAR,
- VIEW_TYPE_EXTENSION_POPUP,
- VIEW_TYPE_NOTIFICATION,
- VIEW_TYPE_PANEL,
- VIEW_TYPE_TAB_CONTENTS,
-};
-
-// Constant strings corresponding to the Type enumeration values. Used
-// when converting JS arguments.
-extern const char kViewTypeAll[];
-extern const char kViewTypeAppShell[];
-extern const char kViewTypeBackgroundPage[];
-extern const char kViewTypeExtensionDialog[];
-extern const char kViewTypeInfobar[];
-extern const char kViewTypeNotification[];
-extern const char kViewTypePanel[];
-extern const char kViewTypePopup[];
-extern const char kViewTypeTabContents[];
-
-} // namespace chrome
-
-#endif // CHROME_COMMON_VIEW_TYPE_H_

Powered by Google App Engine
This is Rietveld 408576698