Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Unified Diff: chrome/browser/extensions/extension_process_manager.h

Issue 13375017: Move the ViewType enum to extensions\common. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_process_manager.h
===================================================================
--- chrome/browser/extensions/extension_process_manager.h (revision 191609)
+++ chrome/browser/extensions/extension_process_manager.h (working copy)
@@ -13,9 +13,9 @@
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "base/time.h"
-#include "chrome/common/view_type.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
+#include "extensions/common/view_type.h"
class Browser;
class GURL;
@@ -56,10 +56,10 @@
const extensions::Extension* extension,
const GURL& url,
Browser* browser,
- chrome::ViewType view_type);
+ extensions::ViewType view_type);
extensions::ExtensionHost* CreateViewHost(const GURL& url,
- Browser* browser,
- chrome::ViewType view_type);
+ Browser* browser,
+ extensions::ViewType view_type);
extensions::ExtensionHost* CreatePopupHost(
const extensions::Extension* extension,
const GURL& url,
@@ -177,14 +177,14 @@
typedef std::string ExtensionId;
typedef std::map<ExtensionId, BackgroundPageData> BackgroundPageDataMap;
typedef std::map<content::RenderViewHost*,
- chrome::ViewType> ExtensionRenderViews;
+ extensions::ViewType> ExtensionRenderViews;
// Close the given |host| iff it's a background page.
void CloseBackgroundHost(extensions::ExtensionHost* host);
// Ensure browser object is not null except for certain situations.
void EnsureBrowserWhenRequired(Browser* browser,
- chrome::ViewType view_type);
+ extensions::ViewType view_type);
// These are called when the extension transitions between idle and active.
// They control the process of closing the background page when idle.

Powered by Google App Engine
This is Rietveld 408576698