Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1890)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 13375017: Move the ViewType enum to extensions\common. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/lazy_background_task_queue.cc ('K') | « chrome/browser/ui/views/extensions/extension_view_views.cc ('k') | chrome/browser/view_type_utils.h » ('j') | chrome/browser/view_type_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
===================================================================
--- chrome/browser/ui/webui/extensions/extension_settings_handler.cc (revision 191609)
+++ chrome/browser/ui/webui/extensions/extension_settings_handler.cc (working copy)
@@ -1018,10 +1018,10 @@
iter != views.end(); ++iter) {
RenderViewHost* host = *iter;
WebContents* web_contents = WebContents::FromRenderViewHost(host);
- chrome::ViewType host_type = chrome::GetViewType(web_contents);
+ extensions::ViewType host_type = chrome::GetViewType(web_contents);
if (host == deleting_rvh_ ||
- chrome::VIEW_TYPE_EXTENSION_POPUP == host_type ||
- chrome::VIEW_TYPE_EXTENSION_DIALOG == host_type)
+ extensions::VIEW_TYPE_EXTENSION_POPUP == host_type ||
+ extensions::VIEW_TYPE_EXTENSION_DIALOG == host_type)
continue;
GURL url = web_contents->GetURL();
« chrome/browser/extensions/lazy_background_task_queue.cc ('K') | « chrome/browser/ui/views/extensions/extension_view_views.cc ('k') | chrome/browser/view_type_utils.h » ('j') | chrome/browser/view_type_utils.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698