Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 13375017: Move the ViewType enum to extensions\common. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/developer_private/developer_private_api.cc ('K') | « chrome/browser/extensions/api/messaging/message_service.cc ('k') | chrome/browser/extensions/event_router.cc » ('j') | chrome/browser/extensions/extension_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
===================================================================
--- chrome/browser/extensions/api/web_navigation/web_navigation_api.cc (revision 191609)
+++ chrome/browser/extensions/api/web_navigation/web_navigation_api.cc (working copy)
@@ -119,7 +119,8 @@
if (!tab_observer) {
// If you hit this DCHECK(), please add reproduction steps to
// http://crbug.com/109464.
- DCHECK(chrome::GetViewType(old_contents) != chrome::VIEW_TYPE_TAB_CONTENTS);
+ DCHECK(chrome::GetViewType(old_contents) !=
+ extensions::VIEW_TYPE_TAB_CONTENTS);
Yoyo Zhou 2013/04/01 17:36:51 ''
return;
}
const FrameNavigationState& frame_navigation_state =
@@ -168,7 +169,7 @@
// If you hit this DCHECK(), please add reproduction steps to
// http://crbug.com/109464.
DCHECK(chrome::GetViewType(details->source_web_contents) !=
- chrome::VIEW_TYPE_TAB_CONTENTS);
+ extensions::VIEW_TYPE_TAB_CONTENTS);
return;
}
const FrameNavigationState& frame_navigation_state =
« chrome/browser/extensions/api/developer_private/developer_private_api.cc ('K') | « chrome/browser/extensions/api/messaging/message_service.cc ('k') | chrome/browser/extensions/event_router.cc » ('j') | chrome/browser/extensions/extension_host.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698