Fixed the problem that cookie blocking notification bubble is not displayed in the omnibox.

Fixed the problem that cookie blocking notification bubble is not displayed in the omnibox.

We can have multiple cookies of different blocked statuses, that means OnContentAllowed() can still be called while the cookies content setting is set to block.
And we need to show the blocking cookie icon if any of the cookie is blocked.

Also, except for media, other content setting types need reloading the page to have the new setting kick in.

BUG=224557
TEST=unit_tests --gtest_filter="*TabSpecificContentSettingsTest*"
manual test:
1.Launch chrome and go to settings > content settings
2.Under cookies select the option "Block third party cookies and site data" 
3.Login to facebook.com and Go to www.latimes.com.
4.Observe the cookie blocking notification bubble in the omnibox.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191844

[no longer working on chromium, 2013-04-02 12:01:26]

Jochen, could you please review this CL?

Thanks,

SX

[jochen (gone - plz use gerrit), 2013-04-02 13:08:53]

lgtm

https://codereview.chromium.org/13375004/diff/2001/chrome/browser/content_set...
File chrome/browser/content_settings/tab_specific_content_settings.cc (right):

https://codereview.chromium.org/13375004/diff/2001/chrome/browser/content_set...
chrome/browser/content_settings/tab_specific_content_settings.cc:318: }
nit, you can just close the if block here, no need for the else block then

[no longer working on chromium, 2013-04-02 14:12:06]

https://codereview.chromium.org/13375004/diff/2001/chrome/browser/content_set...
File chrome/browser/content_settings/tab_specific_content_settings.cc (right):

https://codereview.chromium.org/13375004/diff/2001/chrome/browser/content_set...
chrome/browser/content_settings/tab_specific_content_settings.cc:318: }
On 2013/04/02 13:08:53, jochen wrote:
> nit, you can just close the if block here, no need for the else block then

Done.

[commit-bot: I haz the power, 2013-04-02 14:12:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xians@chromium.org/13375004/6001

[commit-bot: I haz the power, 2013-04-02 17:12:13]

Change committed as 191844