Fixing iframe jank in the local omnibox popup.

chrome/browser/search/suggestion_source_unittest.cc

Index: chrome/browser/search/suggestion_source_unittest.cc
diff --git a/chrome/browser/search/suggestion_source_unittest.cc b/chrome/browser/search/suggestion_source_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..de2daf0dc3339eb384ec4850d4c1ce169900d387
--- /dev/null
+++ b/chrome/browser/search/suggestion_source_unittest.cc
@@ -0,0 +1,104 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/search/suggestion_source.h"
+
+#include "base/bind.h"
+#include "base/memory/ref_counted_memory.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/message_loop.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/test/test_browser_thread.h"
+#include "googleurl/src/gurl.h"
+#include "grit/browser_resources.h"
+#include "net/url_request/url_request.h"
+#include "net/url_request/url_request_context.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class SuggestionSourceTest : public testing::Test {
+ public:
+  SuggestionSourceTest()
+    : message_loop_(MessageLoop::TYPE_IO),
+      io_thread_(content::BrowserThread::IO, &message_loop_),
+      response_(NULL) {
+  }
+
+  SuggestionSource* source() { return source_.get(); }
+  std::string response_string() {
+    if (response_) {
+      return std::string(reinterpret_cast<const char*>(response_->front()),
+                         response_->size());
+    }
+    return "";
+  }
+  net::URLRequest* MockRequest(const std::string& url) {
+    return empty_context_.CreateRequest(GURL(url), NULL);
+  }
+  void StartDataRequest(const std::string& path_and_query) {
+    source()->StartDataRequest(path_and_query, false, callback_);
+  }
+
+ private:
+  virtual void SetUp() {
+    source_.reset(new SuggestionSource());
+    callback_ = base::Bind(&SuggestionSourceTest::SaveResponse,
+                           base::Unretained(this));
+    response_ = NULL;
+  }
+
+  virtual void TearDown() {
+    source_.reset();
+  }
+
+  void SaveResponse(base::RefCountedMemory* data) {
+    response_ = data;
+  }
+
+  MessageLoop message_loop_;
+  content::TestBrowserThread io_thread_;
+
+  scoped_ptr<SuggestionSource> source_;
+  content::URLDataSource::GotDataCallback callback_;
+  net::URLRequestContext empty_context_;
+  scoped_refptr<base::RefCountedMemory> response_;
+};
+
+TEST_F(SuggestionSourceTest, ShouldServiceRequest) {
+  scoped_ptr<net::URLRequest> request;
+  request.reset(MockRequest("http://suggestion/loader.js"));
+  EXPECT_FALSE(source()->ShouldServiceRequest(request.get()));
+  request.reset(MockRequest("chrome-search://bogus/loader.js"));
+  EXPECT_FALSE(source()->ShouldServiceRequest(request.get()));
+  request.reset(MockRequest("chrome-search://suggestion/bogus.js"));
+  EXPECT_FALSE(source()->ShouldServiceRequest(request.get()));
+  request.reset(MockRequest("chrome-search://suggestion/loader.js"));
+  EXPECT_TRUE(source()->ShouldServiceRequest(request.get()));
+  request.reset(MockRequest("chrome-search://suggestion/loader.js?origin=1"));
+  EXPECT_TRUE(source()->ShouldServiceRequest(request.get()));
+}
+
+TEST_F(SuggestionSourceTest, GetMimeType) {
+  // URLDataManagerBackend does not include / in path_and_query.
+  EXPECT_EQ("text/html", source()->GetMimeType("loader.html"));
+  EXPECT_EQ("application/javascript",
+            source()->GetMimeType("loader.js?origin=bar"));
+  EXPECT_EQ("", source()->GetMimeType("bogus.html"));
+}
+
+TEST_F(SuggestionSourceTest, StartDataRequest) {
+  StartDataRequest("bogus.html");
+  EXPECT_TRUE(response_string().empty());
+  StartDataRequest("loader.html?origin=chunkybacon");

[Dan Beam, 2013/04/08 16:46:58]

chunky bacon!?

[Jered, 2013/04/08 21:43:16]

:-)
http://akuaku.org/images/chunky%20bacon.png

+  EXPECT_FALSE(response_string().empty());
+  EXPECT_EQ(std::string::npos, response_string().find("chunkybacon"));
+  StartDataRequest("loader.js");
+  EXPECT_TRUE(response_string().empty());
+  StartDataRequest("loader.js?origin=chunkybacon");
+  EXPECT_FALSE(response_string().empty());
+  EXPECT_NE(std::string::npos, response_string().find("\"chunkybacon\""));
+  StartDataRequest("loader.js?origin=bacon%22;alert('evil');x=%22");
+  EXPECT_FALSE(response_string().empty());
+  EXPECT_NE(std::string::npos,
+            response_string().find("bacon\\\";alert('evil');x=\\\""));
+}