Fixing iframe jank in the local omnibox popup.

chrome/browser/search/suggestion_source.h

Index: chrome/browser/search/suggestion_source.h
diff --git a/chrome/browser/search/suggestion_source.h b/chrome/browser/search/suggestion_source.h
new file mode 100644
index 0000000000000000000000000000000000000000..a1eb385bc5b534037aee402a859a476846ffe85a
--- /dev/null
+++ b/chrome/browser/search/suggestion_source.h
@@ -0,0 +1,45 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SEARCH_SUGGESTION_SOURCE_H_
+#define CHROME_BROWSER_SEARCH_SUGGESTION_SOURCE_H_
+
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+#include "content/public/browser/url_data_source.h"
+
+// Serves HTML for displaying suggestions using iframes, e.g.
+// chrome-search://suggestion/loader.html
+class SuggestionSource : public content::URLDataSource {
+ public:
+  SuggestionSource();
+  virtual ~SuggestionSource();
+
+  // Overridden from content::URLDataSource:

[samarth, 2013/04/02 23:26:58]

These can be private.

[Jered, 2013/04/04 17:30:10]

Done.

+  virtual std::string GetSource() OVERRIDE;
+  virtual void StartDataRequest(
+      const std::string& path,
+      bool is_incognito,
+      const content::URLDataSource::GotDataCallback& callback) OVERRIDE;
+  virtual std::string GetMimeType(const std::string& path) const OVERRIDE;
+  virtual bool ShouldDenyXFrameOptions() const OVERRIDE;
+  virtual bool ShouldServiceRequest(
+      const net::URLRequest* request) const OVERRIDE;
+
+ private:
+  // Sends unmodified resource bytes.
+  void SendResource(
+      int resource_id,
+      const content::URLDataSource::GotDataCallback& callback);
+
+  // Sends Javascript with a parameter substituted.
+  void SendJSWithOrigin(
+      int resource_id,
+      const std::string& path,
+      const content::URLDataSource::GotDataCallback& callback);
+
+  DISALLOW_COPY_AND_ASSIGN(SuggestionSource);
+};
+
+#endif  // CHROME_BROWSER_SEARCH_SUGGESTION_SOURCE_H_