chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.html - Issue 13375003: Fixing iframe jank in the local omnibox popup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.html

Issue 13375003: Fixing iframe jank in the local omnibox popup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressing comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css ('K') | « chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css ('k') | chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.js » ('j') | chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.html

diff --git a/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.html b/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.html

index 6821f96e63363685fcf308fd38a159491de6e4cc..3c3c41e7dde05343af31974ac59895f10f9450dc 100644

--- a/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.html

+++ b/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.html

@@ -10,6 +10,9 @@

href="chrome-search://local-omnibox-popup/local-omnibox-popup.css"></link>

</head>

<body>

- <div id="suggestions-box-container"></div>

+ <iframe hidden src="chrome-search://suggestion/loader.html"

+ id="suggestion-loader"></iframe>

Dan Beam 2013/04/09 03:56:05 nit: put hidden last

Jered 2013/04/09 21:59:38 Done.

+ <div class="active-container"></div>

+ <div class="pending-container"></div>

</body>

</html>