chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.html - Issue 13375003: Fixing iframe jank in the local omnibox popup.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.html

Issue 13375003: Fixing iframe jank in the local omnibox popup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adding unit tests. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <!-- Copyright 2012 The Chromium Authors. All rights reserved.	3 <!-- Copyright 2012 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7 <head>	7 <head>

8 <script src="chrome-search://local-omnibox-popup/local-omnibox-popup.js"></scr ipt>	8 <script src="chrome-search://local-omnibox-popup/local-omnibox-popup.js"></scr ipt>

9 <link rel="stylesheet"	9 <link rel="stylesheet"

10 href="chrome-search://local-omnibox-popup/local-omnibox-popup.css"></link>	10 href="chrome-search://local-omnibox-popup/local-omnibox-popup.css"></link>

11 </head>	11 </head>

12 <body>	12 <body>

13 <div id="suggestions-box-container"></div>	13 <iframe style="display:none"
	Dan Beam 2013/04/08 16:46:58 ^ use hidden instead of style="display:none;" ^ use hidden instead of style="display:none;" Jered 2013/04/08 21:43:16 Done. Show quoted text On 2013/04/08 16:46:58, Dan Beam wrote: > ^ use hidden instead of style="display:none;" Done.
	14 src="chrome-search://suggestion/loader.html"

	15 id="suggestion-loader"></iframe>

	16 <div class="active-container"></div>

	17 <div class="pending-container"></div>

14 </body>	18 </body>

15 </html>	19 </html>

OLD	NEW