chrome/browser/resources/omnibox_result.html - Issue 13375003: Fixing iframe jank in the local omnibox popup.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/omnibox_result.html

Issue 13375003: Fixing iframe jank in the local omnibox popup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Include missing file. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.js ('K') | « chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.js ('k') | chrome/browser/resources/omnibox_result.js » ('j') | chrome/browser/resources/omnibox_result.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="chrome-search://suggestion/result.js"></script>

	5 <style>

	6 body {

	7 -webkit-user-select: none;

	8 cursor: default;

	9 margin: 0;

	10 overflow: hidden;

	11 position: fixed;

	12 width: 100%;

	13 }

	14 body > div {

	15 overflow: hidden;

	16 text-overflow: ellipsis;

	17 white-space: nowrap;

	18 }

	19 .hide { display: none; }

	20 </style>

	21 </head>

	22 <body>

	23 <div>

	24 <span id="url"></span>
	samarth 2013/04/02 23:26:58 In the other search provider case, are these ifram In the other search provider case, are these iframes also showing queries? I'd try to make that more obvious. Jered 2013/04/03 18:49:33 Per offline discussion, they're currently showing Show quoted text On 2013/04/02 23:26:58, samarth wrote: > In the other search provider case, are these iframes also showing queries? I'd > try to make that more obvious. Per offline discussion, they're currently showing search URLs. Would you prefer I clean this up now or in a follow on change? Jered 2013/04/03 18:50:32 Oh never mind I ended up doing this. Show quoted text On 2013/04/03 18:49:33, Jered wrote: > On 2013/04/02 23:26:58, samarth wrote: > > In the other search provider case, are these iframes also showing queries? I'd > > try to make that more obvious. > > Per offline discussion, they're currently showing search URLs. Would you prefer > I clean this up now or in a follow on change? Oh never mind I ended up doing this.
	25 <span id="optional"> – <span id="title"></span></span>

	26 </div>

	27 </body>

	28 </html>

OLD	NEW