Fixing iframe jank in the local omnibox popup.

content/browser/webui/web_ui_data_source_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/utf_string_conversions.h"
 #include "content/browser/webui/web_ui_data_source_impl.h"
 #include "content/test/test_content_client.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 41 matching lines @@
 
 class WebUIDataSourceTest : public testing::Test {
  public:
   WebUIDataSourceTest() : result_data_(NULL) {}
   virtual ~WebUIDataSourceTest() {}
   WebUIDataSourceImpl* source() { return source_.get(); }
 
   void StartDataRequest(const std::string& path) {
      source_->StartDataRequest(
         path,
-        false,
+        0, 0,

[palmer, 2013/04/22 19:38:37]

Elsewhere, you used -1 to indicate no particular IDs. Which is right?

[Jered, 2013/04/22 23:02:58]

It's a no-op in all these test cases because it's ignored. I just haphazardly
picked 0. Would -1 be clearer?

[palmer, 2013/04/23 00:34:24]

I only asked because you used -1 elsewhere, and it seems better to have just one
"this value is meaningless" value. It's not a huge deal.

         base::Bind(&WebUIDataSourceTest::SendResult,
         base::Unretained(this)));
   }
 
   std::string GetMimeType(const std::string& path) const {
     return source_->GetMimeType(path);
   }
 
   scoped_refptr<base::RefCountedMemory> result_data_;
 
@@ skipping 72 matching lines @@
   EXPECT_EQ(GetMimeType("foo"), html);
   EXPECT_EQ(GetMimeType("foo.html"), html);
   EXPECT_EQ(GetMimeType(".js"), js);
   EXPECT_EQ(GetMimeType("foo.js"), js);
   EXPECT_EQ(GetMimeType("js"), html);
   EXPECT_EQ(GetMimeType("foojs"), html);
   EXPECT_EQ(GetMimeType("foo.jsp"), html);
 }
 
 }  // namespace content