Fixing iframe jank in the local omnibox popup.

chrome/renderer/chrome_content_renderer_client_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_builder.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
@@ skipping 324 matching lines @@
       GURL("filesystem:chrome-extension://" +
            kRandomExtensionID + "/foo")));
   EXPECT_TRUE(client.IsRequestOSFileHandleAllowedForURL(
       GURL("filesystem:http://127.0.0.1/foo")));
   EXPECT_FALSE(client.IsRequestOSFileHandleAllowedForURL(
       GURL("http://127.0.0.1/foo")));
   EXPECT_TRUE(client.IsRequestOSFileHandleAllowedForURL(
       GURL("filesystem:http://192.168.0.1/foo")));
 }
 
+TEST_F(ChromeContentRendererClientTest, SetOriginForSuggestionRequest) {
+  ChromeContentRendererClient client;
+  GURL result;
+  client.SetOriginForSuggestionRequest(
+      GURL("chrome-search://suggestion/result.js"),
+      GURL("http://sanity.example.com"), &result);
+  EXPECT_EQ(
+      GURL("chrome-search://suggestion/result.js?"
+           "origin=http://sanity.example.com"), result);
+  client.SetOriginForSuggestionRequest(
+      GURL("chrome-search://suggestion/result.js?"
+           "origin=http://good.example.com/"),
+      GURL("http://evil.example.com"), &result);
+  EXPECT_EQ(
+      GURL("chrome-search://suggestion/result.js?"
+           "origin=http://evil.example.com"), result);

[palmer, 2013/04/09 00:26:15]

What about malformed and incomplete origins, and multiple origin parameters?

[Jered, 2013/04/09 01:18:58]

Do you mean what if the top_url param is malformed or incomplete, i.e. the
webframe URL is invalid? [The entire query string is replaced, but sure, I can
add some tests for multiple params too.]

[Jered, 2013/04/09 03:24:24]

Done, I think.

+}
+
 }  // namespace chrome