chrome/common/extensions/api/windows.json - Issue 13375002: Revert issue 158379 (chrome.window.create height)

Unified Diff: chrome/common/extensions/api/windows.json

Issue 13375002: Revert issue 158379 (chrome.window.create height) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/test/data/extensions/api_test/window_open/window_size/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/windows.json

diff --git a/chrome/common/extensions/api/windows.json b/chrome/common/extensions/api/windows.json

index 11572e29d989a4a2cd42a623b8dcdb4829509c72..f59ce956ee19b0a5454dbe330201c6daa1d57b46 100644

--- a/chrome/common/extensions/api/windows.json

+++ b/chrome/common/extensions/api/windows.json

@@ -17,8 +17,8 @@

"focused": {"type": "boolean", "description": "Whether the window is currently the focused window."},

"top": {"type": "integer", "optional": true, "description": "The offset of the window from the top edge of the screen in pixels. Under some circumstances a Window may not be assigned top property, for example when querying closed windows from the $ref:sessionRestore API."},

"left": {"type": "integer", "optional": true, "description": "The offset of the window from the left edge of the screen in pixels. Under some circumstances a Window may not be assigned left property, for example when querying closed windows from the $ref:sessionRestore API."},

- "width": {"type": "integer", "optional": true, "description": "The width of the window in pixels. Under some circumstances a Window may not be assigned width property, for example when querying closed windows from the $ref:sessionRestore API."},

- "height": {"type": "integer", "optional": true, "description": "The height of the window in pixels. Under some circumstances a Window may not be assigned height property, for example when querying closed windows from the $ref:sessionRestore API."},

+ "width": {"type": "integer", "optional": true, "description": "The width of the window, including the frame, in pixels. Under some circumstances a Window may not be assigned width property, for example when querying closed windows from the $ref:sessionRestore API."},

+ "height": {"type": "integer", "optional": true, "description": "The height of the window, including the frame, in pixels. Under some circumstances a Window may not be assigned height property, for example when querying closed windows from the $ref:sessionRestore API."},

"tabs": {"type": "array", "items": { "$ref": "tabs.Tab" }, "optional": true, "description": "Array of $ref:tabs.Tab objects representing the current tabs in the window."},

"incognito": {"type": "boolean", "description": "Whether the window is incognito."},

"type": {

@@ -170,8 +170,8 @@

"tabId": {"type": "integer", "minimum": 0, "optional": true, "description": "The id of the tab for which you want to adopt to the new window."},

"left": {"type": "integer", "optional": true, "description": "The number of pixels to position the new window from the left edge of the screen. If not specified, the new window is offset naturally from the last focused window. This value is ignored for panels."},

"top": {"type": "integer", "optional": true, "description": "The number of pixels to position the new window from the top edge of the screen. If not specified, the new window is offset naturally from the last focused window. This value is ignored for panels."},

- "width": {"type": "integer", "minimum": 0, "optional": true, "description": "The width in pixels of the new window. If not specified defaults to a natural width."},

- "height": {"type": "integer", "minimum": 0, "optional": true, "description": "The height in pixels of the new window. If not specified defaults to a natural height."},

+ "width": {"type": "integer", "minimum": 0, "optional": true, "description": "The width in pixels of the new window, including the frame. If not specified defaults to a natural width."},

+ "height": {"type": "integer", "minimum": 0, "optional": true, "description": "The height in pixels of the new window, including the frame. If not specified defaults to a natural height."},

"focused": {"type": "boolean", "optional": true, "description": "If true, opens an active window. If false, opens an inactive window."},

"incognito": {"type": "boolean", "optional": true, "description": "Whether the new window should be an incognito window."},

"type": {