Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: build/android/buildbot/bb_device_status_check.py

Issue 1337463002: [Android] Fix low-battery blacklisting in device_status_check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_device_status_check.py
diff --git a/build/android/buildbot/bb_device_status_check.py b/build/android/buildbot/bb_device_status_check.py
index 74d50ae00aa08334e915f4a0537450db49f07500..154e3c574cc541abe98625203aa7a1a6054f28bd 100755
--- a/build/android/buildbot/bb_device_status_check.py
+++ b/build/android/buildbot/bb_device_status_check.py
@@ -68,7 +68,7 @@ def _BatteryStatus(device, blacklist):
if not battery.GetCharging():
battery.SetCharging(True)
if blacklist:
- blacklist.Extend([device.GetDeviceSerial()])
+ blacklist.Extend([device.adb.GetDeviceSerial()])
except device_errors.CommandFailedError:
logging.exception('Failed to get battery information for %s',
@@ -255,11 +255,11 @@ def RecoverDevices(devices, blacklist):
except device_errors.CommandFailedError:
logging.exception('Failure while waiting for %s.', str(device))
if blacklist:
- blacklist.Extend([str(device)])
+ blacklist.Extend([device.adb.GetDeviceSerial()])
except device_errors.CommandTimeoutError:
logging.exception('Timed out while waiting for %s. ', str(device))
if blacklist:
- blacklist.Extend([str(device)])
+ blacklist.Extend([device.adb.GetDeviceSerial()])
device_utils.DeviceUtils.parallel(devices).pMap(blacklisting_recovery)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698