Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1599)

Issue 133743004: ash: Fix use of uninitialized member in initializer list (Closed)

Created:
6 years, 11 months ago by hans
Modified:
6 years, 11 months ago
Reviewers:
jennyz
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

ash: Fix use of uninitialized member in initializer list A recent version of Clang warned about this: ../../ash/system/user/tray_user.cc:1055:20: error: field 'listener_' is uninitialized when used here [-Werror,-Wuninitialized] : CustomButton(listener_), ^ BUG=323668 R=jennyz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/system/user/tray_user.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
hans
Please take a look.
6 years, 11 months ago (2014-01-10 19:03:09 UTC) #1
jennyz
lgtm
6 years, 11 months ago (2014-01-10 21:16:39 UTC) #2
hans
On 2014/01/10 21:16:39, jennyz wrote: > lgtm Thanks!
6 years, 11 months ago (2014-01-10 21:20:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/133743004/1
6 years, 11 months ago (2014-01-10 21:26:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/133743004/1
6 years, 11 months ago (2014-01-10 23:43:45 UTC) #5
hans
Committed patchset #1 manually as r244277 (presubmit successful).
6 years, 11 months ago (2014-01-11 00:07:16 UTC) #6
Nico
6 years, 11 months ago (2014-01-11 00:09:45 UTC) #7
Message was sent while issue was closed.
Nice!

Powered by Google App Engine
This is Rietveld 408576698