Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1337283003: Prepare GuestView for removing swapped out RenderFrame. (Closed)

Created:
5 years, 3 months ago by nasko
Modified:
5 years, 3 months ago
Reviewers:
Fady Samuel, lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare GuestView for removing swapped out RenderFrame. GuestView code is dependent on the usage of swapped out RenderFrame for the out-of-process component. Since swapped out state is going away, this CL removes this dependency. BUG=357747 Committed: https://crrev.com/89aa05ab8d8a42d2587e5ad3cc6ac245519ce588 Cr-Commit-Position: refs/heads/master@{#348662}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added TODO comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M components/guest_view/renderer/guest_view_request.cc View 1 2 chunks +10 lines, -1 line 0 comments Download
M extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337283003/1
5 years, 3 months ago (2015-09-14 15:38:26 UTC) #2
nasko
Hey Istiaque, Can you review this CL for me? It moves GuestView to use the ...
5 years, 3 months ago (2015-09-14 15:40:20 UTC) #4
Fady Samuel
https://codereview.chromium.org/1337283003/diff/1/components/guest_view/renderer/guest_view_request.cc File components/guest_view/renderer/guest_view_request.cc (right): https://codereview.chromium.org/1337283003/diff/1/components/guest_view/renderer/guest_view_request.cc#newcode93 components/guest_view/renderer/guest_view_request.cc:93: if (frame->isWebLocalFrame()) { nit: comment would be helpful. https://codereview.chromium.org/1337283003/diff/1/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc ...
5 years, 3 months ago (2015-09-14 15:42:46 UTC) #6
lazyboy
lgtm
5 years, 3 months ago (2015-09-14 17:04:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337283003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337283003/20001
5 years, 3 months ago (2015-09-14 17:09:00 UTC) #9
Fady Samuel
lgtm
5 years, 3 months ago (2015-09-14 17:09:38 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-14 18:33:51 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/89aa05ab8d8a42d2587e5ad3cc6ac245519ce588 Cr-Commit-Position: refs/heads/master@{#348662}
5 years, 3 months ago (2015-09-14 18:34:30 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:34:43 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89aa05ab8d8a42d2587e5ad3cc6ac245519ce588
Cr-Commit-Position: refs/heads/master@{#348662}

Powered by Google App Engine
This is Rietveld 408576698